Page MenuHomePhabricator
Differential D12122

[policy] Define packages
ClosedPublic
Actions

Authored by PiRK on Oct 3 2022, 16:29.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC74054628d1a9: [policy] Define packages
Summary

Define the Package type as an alias for a vector of transactions for now.
Add PackageValidationResult, similar to TxValidationResult and
BlockValidationResult for package-wide errors that cannot be reported
within a single transaction result, such as having too many
transactions in the package. We can update the concept of
what a package is and have different logic for packages vs lists of
transactions in the future, e.g. for package relay.

This is a backport of core#20833 [4/13]
https://github.com/bitcoin/bitcoin/pull/20833/commits/b88d77aec5e7bef5305a668d15031351c0548b4d

Test Plan

ninja

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 3 2022, 16:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 3 2022, 16:29
PiRK requested review of this revision.Oct 3 2022, 16:29
teamcity edited the summary of this revision. (Show Details)Oct 3 2022, 16:30
PiRK added a child revision: D12123: [validation] package validation for test accepts.Oct 3 2022, 16:31
Harbormaster completed remote builds in B20295: Diff 35358.Oct 3 2022, 16:35
teamcity added a comment.Oct 3 2022, 16:35
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 3 2022, 16:35
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 3 2022, 16:36
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 3 2022, 16:36
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 3 2022, 16:37
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 3 2022, 17:25
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 3 2022, 20:58
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 3 2022, 20:58
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 3 2022, 20:58
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 3 2022, 20:58
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 3 2022, 20:58
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 3 2022, 20:58
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
PiRK updated this revision to Diff 35390.Oct 4 2022, 07:56

rebase

Harbormaster completed remote builds in B20323: Diff 35390.Oct 4 2022, 08:38
Fabien accepted this revision.Oct 4 2022, 11:56
This revision is now accepted and ready to land.Oct 4 2022, 11:56
PiRK updated this revision to Diff 35405.Oct 4 2022, 14:22

rebase

Harbormaster completed remote builds in B20335: Diff 35405.Oct 4 2022, 15:58
teamcity added a comment.Oct 4 2022, 15:58
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 4 2022, 16:08
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
This revision was landed with ongoing or failed builds.Oct 5 2022, 06:15
Closed by commit rABC74054628d1a9: [policy] Define packages (authored by glozow <gzhao408@berkeley.edu>, committed by PiRK). · Explain Why
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC74054628d1a9: [policy] Define packages.

Revision Contents
Changeset List

PathSize
src/
policy/
36 lines

Diff 35429

View Options

src/policy/packages.h

Loading...