Page MenuHomePhabricator
Differential D12126

[test] functional test for packages in RPCs
ClosedPublic
Actions

Authored by PiRK on Oct 3 2022, 16:40.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC18edb8cd82cb: [test] functional test for packages in RPCs
Summary

This is a backport of core#20833 [11 / 13]
https://github.com/bitcoin/bitcoin/pull/20833/commits/c4259f4b7ee23ef6e0ec82c5d5b9dfa9cadd5bed

Notes:

  • I used the FromHex and ToHex helper functions when serializing / deserializing transactions
  • all occurences of CTransaction.rehash() have been changed into CTransaction.get_id(), as there was no point in recomputing the txid without change to the transaction
  • test_rbf has been deleted for obvious reasons
  • in test_independant, one of the tests differs from the source material because we do not test the missing inputs first in all transactions and abort early without checking any signature, we need to check the signatures for all transactions until we find an invalid transaction, so we can validate all previous transactions until the first bad tx is met in the package (see D12123).
  • in test_multiple_children I had to fix a call to self.chain_transaction in which the source material mistakenly passed the child_value instead of the parent value when building Child A.

Depends on D12125

Test Plan

ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 3 2022, 16:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 3 2022, 16:40
PiRK requested review of this revision.Oct 3 2022, 16:40
teamcity edited the summary of this revision. (Show Details)Oct 3 2022, 16:40
Harbormaster completed remote builds in B20299: Diff 35363.Oct 3 2022, 17:27
teamcity added a comment.Oct 3 2022, 17:27
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 3 2022, 17:28
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 3 2022, 17:28
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 3 2022, 17:28
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 3 2022, 17:29
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
PiRK updated this revision to Diff 35394.Oct 4 2022, 07:59

rebase

PiRK added a child revision: D12133: [policy] detect unsorted packages.Oct 4 2022, 08:24
Harbormaster completed remote builds in B20327: Diff 35394.Oct 4 2022, 09:07
Fabien accepted this revision.Oct 4 2022, 15:02
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/rpc_packages.py
31 ↗(On Diff #35394)
This revision is now accepted and ready to land.Oct 4 2022, 15:02
PiRK updated this revision to Diff 35412.Oct 4 2022, 17:58

indeces -> indices

Harbormaster completed remote builds in B20341: Diff 35412.Oct 4 2022, 18:14
Closed by commit rABC18edb8cd82cb: [test] functional test for packages in RPCs (authored by PiRK). · Explain WhyOct 5 2022, 06:15
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC18edb8cd82cb: [test] functional test for packages in RPCs.

Revision Contents
Changeset List

PathSize
test/
functional/
377 lines

Diff 35433

View Options

test/functional/rpc_packages.py

Loading...