Paths

Table of Contentst

Differential D12133

[policy] detect unsorted packages
ClosedPublic
Actions

Authored by PiRK on Oct 4 2022, 08:24.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC855ed5d51112: [policy] detect unsorted packages

Summary

Quit early if a package is not topologically sorted, so if we later get a missing-inputs status we know that it is caused by an orphan tx or a tx trying to spend non-existing coins.

This concludes backport of core#20833
https://github.com/bitcoin/bitcoin/pull/20833/commits/13650fe2e527bf0cf5d977bf5f3f1563b853ecdc

Depends on D12126

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 4 2022, 08:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 4 2022, 08:24

PiRK requested review of this revision.Oct 4 2022, 08:24

teamcity edited the summary of this revision. (Show Details)Oct 4 2022, 08:24

PiRK edited the summary of this revision. (Show Details)Oct 4 2022, 08:29

Harbormaster completed remote builds in B20328: Diff 35395.Oct 4 2022, 09:18

PiRK added a child revision: D12134: [refactor] comment/naming improvements.Oct 4 2022, 09:54

Fabien requested changes to this revision.Oct 4 2022, 16:18

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/validation.cpp
786 ↗	(On Diff #35395)	This is you use-before-init, just pass the args to emplace

This revision now requires changes to proceed.Oct 4 2022, 16:18

use correct emplace usage and revert initializing m_sig_checks_standard

PiRK edited the summary of this revision. (Show Details)Oct 4 2022, 18:03

Fabien accepted this revision.Oct 4 2022, 18:23

This revision is now accepted and ready to land.Oct 4 2022, 18:23

Harbormaster completed remote builds in B20342: Diff 35413.Oct 4 2022, 18:33

Closed by commit rABC855ed5d51112: [policy] detect unsorted packages (authored by glozow <gzhao408@berkeley.edu>, committed by PiRK). · Explain WhyOct 5 2022, 06:15

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC855ed5d51112: [policy] detect unsorted packages.

Revision Contents
Changeset List

Path

Size

src/

validation.cpp

38 lines

test/

functional/

rpc_packages.py

10 lines

Diff 35434

View Options

src/validation.cpp