Page MenuHomePhabricator
Differential D12124

[policy] limit package sizes
ClosedPublic
Actions

Authored by PiRK on Oct 3 2022, 16:34.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC8ce587f87653: [policy] limit package sizes
Summary

Maximum number of transactions allowed in a package is 25, equal to the
default mempool descendant limit: if a package has more transactions
than this, either it would fail default mempool descendant limit or the
transactions don't all have a dependency relationship (but then they
shouldn't be in a package together). Same rationale for 101KvB virtual
size package limit.

Note that these policies are only used in test accepts so far.

This is a backport of core#20833 [8/13] and core#22084 [1/4]
https://github.com/bitcoin/bitcoin/pull/20833/commits/ae8e6df709ff3d52b8e9918e09cacb64f83ae379
https://github.com/bitcoin/bitcoin/pull/22084/commits/6c5f19d9c4d267c54f4dbc4f9d65370ff1e0625b

Depends on D12123

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 3 2022, 16:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 3 2022, 16:34
PiRK requested review of this revision.Oct 3 2022, 16:34
teamcity edited the summary of this revision. (Show Details)Oct 3 2022, 16:34
PiRK added a child revision: D12125: [rpc] allow multiple txns in testmempoolaccept.Oct 3 2022, 16:38
Harbormaster completed remote builds in B20297: Diff 35360.Oct 3 2022, 17:25
teamcity added a comment.Oct 3 2022, 17:25
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 3 2022, 17:25
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 3 2022, 17:26
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 3 2022, 17:26
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 3 2022, 17:26
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
teamcity added a comment.Oct 3 2022, 17:26
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
PiRK updated this revision to Diff 35392.Oct 4 2022, 07:57

rebase

Harbormaster completed remote builds in B20325: Diff 35392.Oct 4 2022, 08:56
Fabien accepted this revision.Oct 4 2022, 13:03
This revision is now accepted and ready to land.Oct 4 2022, 13:03
Closed by commit rABC8ce587f87653: [policy] limit package sizes (authored by glozow <gzhao408@berkeley.edu>, committed by PiRK). · Explain WhyOct 5 2022, 06:15
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC8ce587f87653: [policy] limit package sizes.

Revision Contents
Changeset List

PathSize
src/
policy/
7 lines
test/
73 lines
20 lines

Diff 35431

View Options

src/policy/packages.h

Loading...
View Options

src/test/txvalidation_tests.cpp

Loading...
View Options

src/validation.cpp

Loading...