Page MenuHomePhabricator
Differential D12134

[refactor] comment/naming improvements
ClosedPublic
Actions

Authored by PiRK on Oct 4 2022, 09:54.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC53143ed5ed33: [refactor] comment/naming improvements
Summary

This backports the rest of the changes that are not already squashed with other commits in the core#20833 stack. The reason they were not included with other commits is that the relevant code was already landed before I noticed this follow-up (D12101)

This is a partial backport of core#22084
https://github.com/bitcoin/bitcoin/pull/22084/commits/e8ecc621be6afd3252c0f8147e42c3b4918f7f46

Depends on D12133

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 4 2022, 09:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 4 2022, 09:54
PiRK requested review of this revision.Oct 4 2022, 09:54
teamcity edited the summary of this revision. (Show Details)Oct 4 2022, 09:54
PiRK added a child revision: D12135: MOVEONLY: context-free package policies.Oct 4 2022, 09:55
Harbormaster completed remote builds in B20330: Diff 35397.Oct 4 2022, 10:14
teamcity added a comment.Oct 4 2022, 10:14
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Fabien requested changes to this revision.Oct 4 2022, 16:17
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/txmempool.cpp
587 ↗(On Diff #35397)

If you do this one you can do the miner_tests as well

This revision now requires changes to proceed.Oct 4 2022, 16:17
teamcity added a comment.Oct 4 2022, 17:26
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
PiRK updated this revision to Diff 35414.Oct 4 2022, 18:04

rename view_mempool in miner_tests

Fabien accepted this revision.Oct 4 2022, 18:23
This revision is now accepted and ready to land.Oct 4 2022, 18:23
Harbormaster completed remote builds in B20343: Diff 35414.Oct 4 2022, 18:45
Closed by commit rABC53143ed5ed33: [refactor] comment/naming improvements (authored by PiRK). · Explain WhyOct 5 2022, 06:16
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC53143ed5ed33: [refactor] comment/naming improvements.

Revision Contents
Changeset List

PathSize
src/
test/
4 lines
6 lines
4 lines
8 lines

Diff 35435

View Options

src/test/miner_tests.cpp

Loading...
View Options

src/txmempool.h

Loading...
View Options

src/txmempool.cpp

Loading...
View Options

src/validation.h

Loading...