Page MenuHomePhabricator

[refactor] comment/naming improvements
ClosedPublic

Authored by PiRK on Oct 4 2022, 09:54.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC53143ed5ed33: [refactor] comment/naming improvements
Summary

This backports the rest of the changes that are not already squashed with other commits in the core#20833 stack. The reason they were not included with other commits is that the relevant code was already landed before I noticed this follow-up (D12101)

This is a partial backport of core#22084
https://github.com/bitcoin/bitcoin/pull/22084/commits/e8ecc621be6afd3252c0f8147e42c3b4918f7f46

Depends on D12133

Test Plan

ninja all check-all

Event Timeline

PiRK requested review of this revision.Oct 4 2022, 09:54
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Fabien requested changes to this revision.Oct 4 2022, 16:17
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/txmempool.cpp
587 ↗(On Diff #35397)

If you do this one you can do the miner_tests as well

This revision now requires changes to proceed.Oct 4 2022, 16:17
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.

rename view_mempool in miner_tests

This revision is now accepted and ready to land.Oct 4 2022, 18:23
This revision was automatically updated to reflect the committed changes.