Page MenuHomePhabricator
Differential D1292

Refactor ParseScript logic to remove `else` conditions
ClosedPublic
Actions

Authored by deadalnix on Apr 16 2018, 20:57.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING4e23fdea1fe5: Refactor ParseScript logic to remove `else` conditions
rABC4e23fdea1fe5: Refactor ParseScript logic to remove `else` conditions
Summary

This makes the code easier to understand by unclumping the logic of the parsing and using C++11 style loops.

Depends on D1290

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
parsescriptnits
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2324
Build 2785: Bitcoin ABC Buildbot (legacy)
Build 2784: arc lint + arc unit

Event Timeline

deadalnix created this revision.Apr 16 2018, 20:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 16 2018, 20:57
teamcity added a subscriber: teamcity.Apr 16 2018, 20:59

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Apr 16 2018, 21:21

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2324: Diff 3517.Apr 16 2018, 21:21
deadalnix added a child revision: D1293: Add basic sanity checking for script pushdata size.Apr 16 2018, 21:44
schancel retitled this revision from Explicit the logic in ParseScript to Refactor ParseScript logic to remove `else` conditions.Apr 16 2018, 22:41
schancel accepted this revision.Apr 16 2018, 22:44
This revision is now accepted and ready to land.Apr 16 2018, 22:44
deadalnix updated this revision to Diff 3523.Apr 17 2018, 00:54

Rebase

Closed by commit rABC4e23fdea1fe5: Refactor ParseScript logic to remove `else` conditions (authored by deadalnix). · Explain WhyApr 17 2018, 00:54
This revision was automatically updated to reflect the committed changes.
teamcity added a comment.Apr 17 2018, 01:18

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Apr 17 2018, 01:37

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2329: Diff 3523.Apr 17 2018, 01:37
nakihito mentioned this in D4727: Merge #13656: Remove the boost/algorithm/string/predicate.hpp dependency.Dec 13 2019, 22:41

Revision Contents
Changeset List

PathSize
src/
58 lines

Diff 3517

View Options

src/core_read.cpp

Loading...