Paths

Table of Contentst

Differential D13415

[tg bot] Improve construction of tg msg
ClosedPublic
Actions

Authored by bytesofman on Mar 21 2023, 21:55.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABCfaf5187412f7: [tg bot] Improve construction of tg msg

Summary

T2972

Message was getting complicated with so many conditionally rendered strings. Build up me message line by line in an array.

Test Plan

npm run msgs and msgs look good

Diff Detail

Repository

rABC Bitcoin ABC

Branch

new-tg-bot-stack

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22583
Build 44786: Build Diff
Build 44785: arc lint + arc unit

Event Timeline

bytesofman created this revision.Mar 21 2023, 21:55

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 21 2023, 21:55

bytesofman requested review of this revision.Mar 21 2023, 21:55

Harbormaster completed remote builds in B22583: Diff 38752.Mar 21 2023, 21:56

bytesofman added a child revision: D13416: [tg bot] Improve mock generation.Mar 21 2023, 21:59

emack accepted this revision.Mar 27 2023, 09:51

This revision is now accepted and ready to land.Mar 27 2023, 09:51

Closed by commit rABCfaf5187412f7: [tg bot] Improve construction of tg msg (authored by bytesofman). · Explain WhyApr 2 2023, 18:25

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCfaf5187412f7: [tg bot] Improve construction of tg msg.

Revision Contents
Changeset List

Path

Size

web/

ecash-telegram-bot/

parse.js

111 lines

test/

mocks/

blocks.js

72 lines

Diff 38752

View Options

web/ecash-telegram-bot/parse.js