Paths

Table of Contentst

Differential D14568

[electrum] public_key_from_private_key return bytes
ClosedPublic
Actions

Authored by PiRK on Oct 2 2023, 11:37.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABCa0043bc5ae99: [electrum] public_key_from_private_key return bytes

Summary

Depends on D14567

The next diff will make most new hex conversions unneccessary by storing keypairs as bytes

Test Plan

python test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25222
Build 50032: Build Diff	electrum-tests
Build 50031: arc lint + arc unit

Event Timeline

PiRK created this revision.Oct 2 2023, 11:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 2 2023, 11:37

PiRK requested review of this revision.Oct 2 2023, 11:37

Harbormaster completed remote builds in B25222: Diff 42475.Oct 2 2023, 11:38

PiRK added a child revision: D14569: [electrum] use bytes for pubkey in keypairs arg for tx.sign().Oct 2 2023, 11:38

bytesofman accepted this revision.Oct 2 2023, 13:58

This revision is now accepted and ready to land.Oct 2 2023, 13:58

Closed by commit rABCa0043bc5ae99: [electrum] public_key_from_private_key return bytes (authored by PiRK). · Explain WhyOct 2 2023, 15:33

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCa0043bc5ae99: [electrum] public_key_from_private_key return bytes.

Revision Contents
Changeset List

Path

Size

electrum/

electrumabc/

avalanche/

primitives.py

3 lines

bitcoin.py

11 lines

commands.py

4 lines

tests/

test_bitcoin.py

2 lines

transaction.py

9 lines

wallet.py

2 lines

electrumabc_plugins/

fusion/

fusion.py

5 lines

Diff 42475

View Options

electrum/electrumabc/avalanche/primitives.py

View Options

electrum/electrumabc/bitcoin.py

View Options

electrum/electrumabc/commands.py

View Options

electrum/electrumabc/tests/test_bitcoin.py

View Options

electrum/electrumabc/transaction.py

View Options

electrum/electrumabc/wallet.py

View Options

electrum/electrumabc_plugins/fusion/fusion.py

[electrum] public_key_from_private_key return bytesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 42475

electrum/electrumabc/avalanche/primitives.py

electrum/electrumabc/bitcoin.py

electrum/electrumabc/commands.py

electrum/electrumabc/tests/test_bitcoin.py

electrum/electrumabc/transaction.py

electrum/electrumabc/wallet.py

electrum/electrumabc_plugins/fusion/fusion.py

[electrum] public_key_from_private_key return bytes
ClosedPublic
Actions

Revision Contents
Changeset List