Differential D1468

One more C++11 loop in validation.cpp
ClosedPublic
Actions

Authored by deadalnix on May 29 2018, 18:20.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING86bdb5b870b6: One more C++11 loop in validation.cpp
rABC86bdb5b870b6: One more C++11 loop in validation.cpp

Summary

As per title.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

validcpp11

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2673
Build 3458: Bitcoin ABC Buildbot (legacy)
Build 3457: arc lint + arc unit

Event Timeline

deadalnix created this revision.May 29 2018, 18:20

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 29 2018, 18:20

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC :: Diffs :: Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2673: Diff 4023.May 29 2018, 18:55

jasonbcox added a subscriber: jasonbcox.May 30 2018, 15:04

jasonbcox added inline comments.

src/validation.cpp
5064	Cool. First time I've seen this function.
5273–5274	Trying to understand this part... Is this a line we'd like to add in, but won't for performance reasons?

schancel accepted this revision.May 31 2018, 01:35

This revision is now accepted and ready to land.May 31 2018, 01:35

Closed by commit rABC86bdb5b870b6: One more C++11 loop in validation.cpp (authored by deadalnix). · Explain WhyJun 3 2018, 23:48

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

7 lines

Diff 4023

src/validation.cpp

Loading...