Page MenuHomePhabricator

remove unneeded includes when building without BIP70
ClosedPublic

Authored by PiRK on Feb 12 2024, 16:16.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCf87e0097045b: remove unneeded includes when building without BIP70
Summary

This is a follow-up to D15407
These changes enable building Qt with -no-feature-networkproxy when BIP70 is disabled

Depends on D15427

Test Plan
cmake .. -GNinja -DENABLE_BIP70=OFF
ninja all check-all

Event Timeline

include QDebug only when building without BIP70
See also https://github.com/bitcoin/bitcoin/pull/17165

PiRK published this revision for review.Feb 13 2024, 07:44
Fabien requested changes to this revision.Feb 13 2024, 14:49
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/qt/optionsmodel.cpp
25 ↗(On Diff #45164)

you should include unconditionally

This revision now requires changes to proceed.Feb 13 2024, 14:49

include QDebug unconditionally and rebase to remove D15426 from this stack of commits

This revision is now accepted and ready to land.Feb 13 2024, 20:10