Paths

Table of Contentst

Differential D15428

remove unneeded includes when building without BIP70
ClosedPublic
Actions

Authored by PiRK on Feb 12 2024, 16:16.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCf87e0097045b: remove unneeded includes when building without BIP70

Summary

This is a follow-up to D15407
These changes enable building Qt with -no-feature-networkproxy when BIP70 is disabled

Depends on D15427

Test Plan

cmake .. -GNinja -DENABLE_BIP70=OFF
ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 27105
Build 53776: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 53775: arc lint + arc unit

Event Timeline

PiRK created this revision.Feb 12 2024, 16:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 12 2024, 16:16

include QDebug only when building without BIP70
See also https://github.com/bitcoin/bitcoin/pull/17165

@bot build-without-bip70

teamcity awarded a token.Feb 12 2024, 16:21

PiRK edited the test plan for this revision. (Show Details)Feb 12 2024, 16:21

Harbormaster completed remote builds in B27082: Diff 45163.Feb 12 2024, 16:33

Harbormaster completed remote builds in B27083: Diff 45164.Feb 12 2024, 16:43

PiRK published this revision for review.Feb 13 2024, 07:44

Fabien requested changes to this revision.Feb 13 2024, 14:49

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/qt/optionsmodel.cpp
25 ↗	(On Diff #45164)	you should include unconditionally

This revision now requires changes to proceed.Feb 13 2024, 14:49

include QDebug unconditionally and rebase to remove D15426 from this stack of commits

Harbormaster completed remote builds in B27105: Diff 45190.Feb 13 2024, 16:43

Fabien accepted this revision.Feb 13 2024, 20:10

This revision is now accepted and ready to land.Feb 13 2024, 20:10

Closed by commit rABCf87e0097045b: remove unneeded includes when building without BIP70 (authored by PiRK). · Explain WhyFeb 14 2024, 07:36

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCf87e0097045b: remove unneeded includes when building without BIP70.

Revision Contents
Changeset List

Path

Size

src/

qt/

optionsmodel.cpp

5 lines

paymentserver.cpp

2 lines

Diff 45190

View Options

src/qt/optionsmodel.cpp