Page MenuHomePhabricator
Differential D1564

Add a flag to activate OP_CHECKDATASIG
ClosedPublic
Actions

Authored by deadalnix on Jul 14 2018, 17:26.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGINGc2c31a87e472: Add a flag to activate OP_CHECKDATASIG
rABCc2c31a87e472: Add a flag to activate OP_CHECKDATASIG
Summary

As per title.

Depends on D1563

Test Plan

Add test cases in script_test.json and checkdatasig_tests.cpp

Diff Detail

Repository
rABC Bitcoin ABC
Branch
enablecheckdatasig
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2870
Build 3844: Bitcoin ABC Buildbot (legacy)
Build 3843: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 14 2018, 17:26
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 14 2018, 17:26
teamcity added a subscriber: teamcity.Jul 14 2018, 17:28

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 14 2018, 18:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2870: Diff 4303.Jul 14 2018, 18:06
schancel accepted this revision.Jul 16 2018, 16:46
schancel added a subscriber: schancel.
schancel added inline comments.
src/script/interpreter.h
112

SCRIPT_ENABLE_MAGNETIC_ANOMALY_OPCODES?

I guess it doesn't matter if we don't add any others.

This revision is now accepted and ready to land.Jul 16 2018, 16:46
deadalnix edited the summary of this revision. (Show Details)Jul 16 2018, 18:28
deadalnix added a parent revision: D1563: Add CHECKDATASIG opcode..
deadalnix updated this revision to Diff 4326.Jul 16 2018, 18:40

rebase

teamcity added a comment.Jul 16 2018, 18:40

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B2886: Diff 4326.Jul 16 2018, 19:14
teamcity added a comment.Jul 16 2018, 19:14

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Closed by commit rABCc2c31a87e472: Add a flag to activate OP_CHECKDATASIG (authored by deadalnix). · Explain WhyJul 16 2018, 22:12
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
script/
4 lines
2 lines
test/
13 lines
data/
4 lines
1 line

Diff 4303

View Options

src/script/interpreter.h

Loading...
View Options

src/script/interpreter.cpp

Loading...
View Options

src/test/checkdatasig_tests.cpp

Loading...
View Options

src/test/data/script_tests.json

Loading...
View Options

src/test/scriptflags.cpp

Loading...