Page MenuHomePhabricator
Differential D1569

Refactor IsCompressedOrUncompressedPubKey
ClosedPublic
Actions

Authored by deadalnix on Jul 15 2018, 18:29.

Details

Reviewers
kyuupichan
Group Reviewers
Restricted Project
Commits
rSTAGING73f356e1f6f0: Refactor IsCompressedOrUncompressedPubKey
rABC73f356e1f6f0: Refactor IsCompressedOrUncompressedPubKey
Summary

Using a switch is much more readable than a bunch of nested ifs.

Depends on D1568

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
checkpubkeyencodingrefactor
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2880
Build 3864: Bitcoin ABC Buildbot (legacy)
Build 3863: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 15 2018, 18:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 15 2018, 18:29
teamcity added a subscriber: teamcity.Jul 15 2018, 18:31

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B2876: Diff 4312.Jul 15 2018, 19:10
teamcity added a comment.Jul 15 2018, 19:10

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

kyuupichan requested changes to this revision.Jul 16 2018, 00:09
kyuupichan added a subscriber: kyuupichan.
kyuupichan added inline comments.
src/script/sigencoding.cpp
154 ↗(On Diff #4312)

Even better to collapse the first if in the switch by switching on size instead of the first byte, no?

That gives just 2 entries in the switch other than default, too.

This revision now requires changes to proceed.Jul 16 2018, 00:09
deadalnix updated this revision to Diff 4316.Jul 16 2018, 11:31

Update to switch on size rather than on first byte which simplify the logic.

teamcity added a comment.Jul 16 2018, 11:33

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

kyuupichan accepted this revision.Jul 16 2018, 11:35
This revision is now accepted and ready to land.Jul 16 2018, 11:35
teamcity added a comment.Jul 16 2018, 12:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2880: Diff 4316.Jul 16 2018, 12:12
Closed by commit rABC73f356e1f6f0: Refactor IsCompressedOrUncompressedPubKey (authored by deadalnix). · Explain WhyJul 17 2018, 19:59
This revision was automatically updated to reflect the committed changes.
markblundeberg mentioned this in D3808: Merge #12460: Assert CPubKey::ValidLength to the pubkey's header-relevant size.Aug 6 2019, 18:49
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rABCe1f6c608646e: Merge #12460: Assert CPubKey::ValidLength to the pubkey's header-relevant size.Aug 6 2019, 22:29
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rSTAGINGe1f6c608646e: Merge #12460: Assert CPubKey::ValidLength to the pubkey's header-relevant size.Sep 19 2019, 01:40

Revision Contents
Changeset List

PathSize
src/
script/
34 lines
test/
5 lines

Diff 4316

View Options

src/script/sigencoding.cpp

Loading...
View Options

src/test/sigencoding_tests.cpp

Loading...