Page MenuHomePhabricator
Differential D1572

Use sliced to remove the sighash byte from a signature to check for low S
ClosedPublic
Actions

Authored by deadalnix on Jul 16 2018, 13:20.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING952b999014d9: Use sliced to remove the sighash byte from a signature to check for low S
rABC952b999014d9: Use sliced to remove the sighash byte from a signature to check for low S
Summary

This removes unecessary copies.

Depends on D1571

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
slicedsig
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2882
Build 3868: Bitcoin ABC Buildbot (legacy)
Build 3867: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 16 2018, 13:20
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 16 2018, 13:20
teamcity added a subscriber: teamcity.Jul 16 2018, 13:22

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 16 2018, 14:20

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2882: Diff 4318.Jul 16 2018, 14:20
deadalnix added a child revision: D1577: Ignore sighash when checking for DER encoding..Jul 17 2018, 15:59
jasonbcox accepted this revision.Jul 19 2018, 19:46
This revision is now accepted and ready to land.Jul 19 2018, 19:46
deadalnix updated this revision to Diff 4370.Jul 23 2018, 10:50

rebase

teamcity added a comment.Jul 23 2018, 10:52

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 23 2018, 11:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B2918: Diff 4370.Jul 23 2018, 11:49
Closed by commit rABC952b999014d9: Use sliced to remove the sighash byte from a signature to check for low S (authored by deadalnix). · Explain WhyJul 23 2018, 11:50
This revision was automatically updated to reflect the committed changes.
markblundeberg mentioned this in D2964: Merge #9804: Fixes subscript 0 (&var[0]) where should use (var.data()) instead..May 7 2019, 23:17

Revision Contents
Changeset List

PathSize
src/
8 lines
3 lines
script/
15 lines

Diff 4318

View Options

src/pubkey.h

Loading...
View Options

src/pubkey.cpp

Loading...
View Options

src/script/sigencoding.cpp

Loading...