Page MenuHomePhabricator

[electrum] fix the btchip-python dependency for pip > 24.1
ClosedPublic

Authored by PiRK on Aug 21 2024, 08:33.

Details

Reviewers
roqqit
Group Reviewers
Restricted Project
Commits
rABCfae9d4597a5c: [electrum] fix the btchip-python dependency for pip > 24.1
Summary

The latest btchip-python release contained a malformed dependency that used to be treated as a warning, but is now treated as an error by recent pip version. And even with the slightly older versions of pip currently used in release scripts we already get an error the Windows build, because there is an additional step (compared with the linux appimage build) that already treats this as an error.

It seems like btchip-python is no longer maintained by Ledger, and the proposed fix in https://github.com/LedgerHQ/btchip-python/pull/54 is not going to be merged and released.

This diff changes the requirements file to install a version including that patch, downloaded from github's archive API

Depends on D16667

Test Plan

Checked that the fix works.

python -m venv test-env
source test-env/bin/activate

pip install pip --upgrade
pip --version
pip install -r ~/dev/bitcoin-abc/electrum/contrib/deterministic-build/requirements-binaries.txt
pip install -r ~/dev/bitcoin-abc/electrum/contrib/deterministic-build/requirements-hw.txt
deactivate

Checked that the Windows release script works

contrib/build-wine/build.sh

Checked that the patch commit is based on the latest commit of https://github.com/LedgerHQ/btchip-python/commits/master/ (tag 0.1.32 + 2 commits that fix Fedora packaging).

Checked the archive's sha256sum.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable