Page MenuHomePhabricator
Differential D16705

[electrum] use libsecp256k1 for pubkey recovery (from sig and msg)
ClosedPublic
Actions

Authored by PiRK on Sep 3 2024, 10:37.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCbc020f8f7b51: [electrum] use libsecp256k1 for pubkey recovery (from sig and msg)
Summary

Partial backport of electrum#5947
https://github.com/spesmilo/electrum/pull/5947/commits/288d793893e65466ae60bf8b60963b58b849d48e

Depends on D16690

Test Plan

python test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 3 2024, 10:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 3 2024, 10:37
teamcity edited the summary of this revision. (Show Details)Sep 3 2024, 10:37
Harbormaster completed remote builds in B30159: Diff 49455.Sep 3 2024, 10:39
PiRK added a child revision: D16706: [electrum] hard fail if libsecp256k1 is not found/usable.Sep 3 2024, 10:40
PiRK published this revision for review.Sep 3 2024, 10:45
Fabien accepted this revision.Sep 4 2024, 08:40
Fabien added a subscriber: Fabien.
Fabien added inline comments.
electrum/electrumabc/ecc.py
544 ↗(On Diff #49455)

would be good to avoid this from being done unconditionally so it can be made faster

This revision is now accepted and ready to land.Sep 4 2024, 08:40
PiRK updated this revision to Diff 49474.Sep 4 2024, 10:03

rebase

PiRK added a child revision: D16707: [electrum] remove ecdsa as a direct dependency.Sep 4 2024, 10:04
Harbormaster completed remote builds in B30172: Diff 49474.Sep 4 2024, 10:06
Closed by commit rABCbc020f8f7b51: [electrum] use libsecp256k1 for pubkey recovery (from sig and msg) (authored by PiRK). · Explain WhySep 5 2024, 06:09
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCbc020f8f7b51: [electrum] use libsecp256k1 for pubkey recovery (from sig and msg).

Revision Contents
Changeset List

PathSize
electrum/
electrumabc/
118 lines
22 lines

Diff 49493

View Options

electrum/electrumabc/ecc.py

Loading...
View Options

electrum/electrumabc/msqr.py

Loading...
View Options

electrum/electrumabc/secp256k1.py

Loading...