Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC7f062bb764b6: [CI] build libsecp256k1 for electrum tests

Summary

Until now we tested electrum on CI using the pure-python fallback code of ecdsa.
libsecp256k1 is about to become a hard dependency for electrum, so build it for CI

Test Plan

run tests on CI, check that the python fallback code wasn't used (it would log a warning)

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Wed, Aug 28, 08:44

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Aug 28, 08:44

Harbormaster completed remote builds in B30113: Diff 49389.Wed, Aug 28, 08:44

@bot electrum-tests electrum-functional-tests

Build Bitcoin ABC Diffs / Diff Testing (electrum-functional-tests) failed.

Tail of the build log:

INFO:  Building secp256k1...
~/buildAgent/work/jailed-build/bitcoin-abc/electrum/contrib/build ~/buildAgent/work/jailed-build/bitcoin-abc/abc-ci-builds/electrum-functional-tests
Cloning into 'secp256k1'...
~/buildAgent/work/jailed-build/bitcoin-abc/electrum/contrib/build/secp256k1 ~/buildAgent/work/jailed-build/bitcoin-abc/electrum/contrib/build ~/buildAgent/work/jailed-build/bitcoin-abc/abc-ci-builds/electrum-functional-tests
Already on 'master'
Your branch is up to date with 'origin/master'.
./autogen.sh: 3: autoreconf: not found
ERROR:  Could not run autogen for secp256k1. Please make sure you have automake and libtool installed, and try again.
Build electrum-functional-tests failed with exit code 1

The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.

PiRK mentioned this in D16689: [electrum] ecc: use libsecp256k1 for sign/verify/mul/add.Wed, Aug 28, 14:38

PiRK mentioned this in D16690: [electrum] use libsecp256k1 for signature conversions.

Don't build libsecp in install-dependencies-bullseye.sh, do it as a cmake target
Add a debbuging ls for electrum-functional-tests

@bot electrum-tests electrum-functional-tests

teamcity updated a token.Thu, Aug 29, 08:17

Harbormaster completed remote builds in B30125: Diff 49403.Thu, Aug 29, 08:19

@bot electrum-tests

teamcity updated a token.Thu, Aug 29, 08:27

PiRK mentioned this in D16681: [electrum] properly handle point at infinity and point not on curve.Thu, Aug 29, 08:38

install autoconf package

@bot electrum-functional-tests

Build Bitcoin ABC Diffs / Diff Testing (electrum-functional-tests) failed.

Tail of the build log:

INFO:  Building secp256k1...
~/buildAgent/work/jailed-build/bitcoin-abc/electrum/contrib/build ~/buildAgent/work/jailed-build/bitcoin-abc/abc-ci-builds/electrum-functional-tests
Cloning into 'secp256k1'...
~/buildAgent/work/jailed-build/bitcoin-abc/electrum/contrib/build/secp256k1 ~/buildAgent/work/jailed-build/bitcoin-abc/electrum/contrib/build ~/buildAgent/work/jailed-build/bitcoin-abc/abc-ci-builds/electrum-functional-tests
Already on 'master'
Your branch is up to date with 'origin/master'.
./autogen.sh: 3: autoreconf: not found
ERROR:  Could not run autogen for secp256k1. Please make sure you have automake and libtool installed, and try again.
Build electrum-functional-tests failed with exit code 1

Harbormaster completed remote builds in B30126: Diff 49404.Thu, Aug 29, 08:59

try a cmake based build for functional tests

@bot electrum-functional-tests

Build Bitcoin ABC Diffs / Diff Testing (electrum-functional-tests) failed.

Tail of the build log:

INFO:  Building secp256k1...
~/buildAgent/work/jailed-build/bitcoin-abc/electrum/contrib/build ~/buildAgent/work/jailed-build/bitcoin-abc/abc-ci-builds/electrum-functional-tests
Cloning into 'secp256k1'...
~/buildAgent/work/jailed-build/bitcoin-abc/electrum/contrib/build/secp256k1 ~/buildAgent/work/jailed-build/bitcoin-abc/electrum/contrib/build ~/buildAgent/work/jailed-build/bitcoin-abc/abc-ci-builds/electrum-functional-tests
Already on 'master'
Your branch is up to date with 'origin/master'.
/home/teamcity/buildAgent/work/jailed-build/bitcoin-abc/electrum/contrib/cmake_secp: line 15: cmake: command not found
Build electrum-functional-tests failed with exit code 127

Harbormaster completed remote builds in B30127: Diff 49405.Thu, Aug 29, 09:25

I'm going to need help to make this work. I don't understand the environment in which these tests are running (neither cmake nor autoreconf are available)

revert to using make + autoconf

@bot electrum-functional-tests

Build Bitcoin ABC Diffs / Diff Testing (electrum-functional-tests) failed.

Tail of the build log:

INFO:  Building secp256k1...
~/buildAgent/work/jailed-build/bitcoin-abc/electrum/contrib/build ~/buildAgent/work/jailed-build/bitcoin-abc/abc-ci-builds/electrum-functional-tests
Cloning into 'secp256k1'...
~/buildAgent/work/jailed-build/bitcoin-abc/electrum/contrib/build/secp256k1 ~/buildAgent/work/jailed-build/bitcoin-abc/electrum/contrib/build ~/buildAgent/work/jailed-build/bitcoin-abc/abc-ci-builds/electrum-functional-tests
Already on 'master'
Your branch is up to date with 'origin/master'.
configure.ac:32: installing 'build-aux/compile'
configure.ac:5: installing 'build-aux/config.guess'
configure.ac:5: installing 'build-aux/config.sub'
configure.ac:9: installing 'build-aux/install-sh'
configure.ac:9: installing 'build-aux/missing'
Makefile.am:4: error: Libtool library used but 'LIBTOOL' is undefined
Makefile.am:4:   The usual way to define 'LIBTOOL' is to add 'LT_INIT'
Makefile.am:4:   to 'configure.ac' and run 'aclocal' and 'autoconf' again.
Makefile.am:4:   If 'LT_INIT' is in 'configure.ac', make sure
Makefile.am:4:   its definition is in aclocal's search path.
Makefile.am: installing 'build-aux/depcomp'
parallel-tests: installing 'build-aux/test-driver'
autoreconf: automake failed with exit status: 1
ERROR:  Could not run autogen for secp256k1. Please make sure you have automake and libtool installed, and try again.
Build electrum-functional-tests failed with exit code 1

@bot electrum-functional-tests

teamcity updated a token.Tue, Sep 3, 08:40

remove unrecognized options: --with-bignum

Harbormaster completed remote builds in B30156: Diff 49451.Tue, Sep 3, 08:48

PiRK added a child revision: D16689: [electrum] ecc: use libsecp256k1 for sign/verify/mul/add.Tue, Sep 3, 10:31

PiRK published this revision for review.Tue, Sep 3, 10:45

Fabien accepted this revision.Tue, Sep 3, 15:23

This revision is now accepted and ready to land.Tue, Sep 3, 15:23

Closed by commit rABC7f062bb764b6: [CI] build libsecp256k1 for electrum tests (authored by PiRK). · Explain WhyWed, Sep 4, 08:52

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC7f062bb764b6: [CI] build libsecp256k1 for electrum tests.