Page MenuHomePhabricator
Differential D16677

[electrum] move .encrypt method to ECPubkey class
ClosedPublic
Actions

Authored by PiRK on Aug 23 2024, 19:16.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC98cf2c8bda6a: [electrum] move .encrypt method to ECPubkey class
rABC1d7770150082: Fix permission on numerous files.
Summary

This just makes more sense than having it as a classmethod of the private key class and requiring the pubkey to be provided as an argument.

Depends on D16675

Test Plan

python test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Aug 23 2024, 19:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 23 2024, 19:16
PiRK requested review of this revision.Aug 23 2024, 19:16
Harbormaster completed remote builds in B30074: Diff 49337.Aug 23 2024, 19:18
PiRK edited the summary of this revision. (Show Details)Aug 23 2024, 19:18
PiRK added a parent revision: D16675: [electrum] don't use ecdsa for basic bytes <-> int conversion.
PiRK removed a parent revision: D16676: [electrum] refactor private key class to better abstract ecdsa library usage.
PiRK added a child revision: D16676: [electrum] refactor private key class to better abstract ecdsa library usage.Aug 23 2024, 19:20
PiRK added inline comments.Aug 23 2024, 19:22
electrum/electrumabc/ecc.py
323 ↗(On Diff #49337)

this line is the only change (besides typehints and docstring)

PiRK added a child revision: D16678: [electrum] fix the max value for the ephemeral exponent.Aug 23 2024, 19:49
PiRK removed a child revision: D16676: [electrum] refactor private key class to better abstract ecdsa library usage.Aug 23 2024, 19:54
Alexander1978-nice added a commit: rABC1d7770150082: Fix permission on numerous files..Aug 24 2024, 19:36
bytesofman accepted this revision.Aug 26 2024, 23:26
bytesofman added a subscriber: bytesofman.

TIL this feature

This revision is now accepted and ready to land.Aug 26 2024, 23:26
PiRK updated this revision to Diff 49365.Aug 27 2024, 07:03

rebase

Harbormaster completed remote builds in B30095: Diff 49365.Aug 27 2024, 07:05
Closed by commit rABC98cf2c8bda6a: [electrum] move .encrypt method to ECPubkey class (authored by PiRK). · Explain WhyAug 28 2024, 06:26
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC98cf2c8bda6a: [electrum] move .encrypt method to ECPubkey class.

Revision Contents
Changeset List

PathSize
electrum/
electrumabc/
11 lines
59 lines
3 lines
tests/
3 lines
electrumabc_gui/
qt/
5 lines
electrumabc_plugins/
cosigner_pool/
4 lines

Diff 49380

View Options

electrum/electrumabc/commands.py

Loading...
View Options

electrum/electrumabc/ecc.py

Loading...
View Options

electrum/electrumabc/storage.py

Loading...
View Options

electrum/electrumabc/tests/test_ecc.py

Loading...
View Options

electrum/electrumabc_gui/qt/main_window.py

Loading...
View Options

electrum/electrumabc_plugins/cosigner_pool/qt.py

Loading...