Page MenuHomePhabricator
Differential D16682

[electrum] use GENERATOR and CURVE_ORDER from ecc module
ClosedPublic
Actions

Authored by PiRK on Mon, Aug 26, 15:16.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCcec785ad7fc4: [electrum] use GENERATOR and CURVE_ORDER from ecc module
Summary

This replaces instances of ecdsa.ecdsa.generator_secp256k1 (instance of ecdsa.ellipticcurve.Point) with a ECPubkey instance.

After this diff, the only modules still importing ecdsa are:

  • ecc.py
  • ecc_fast.py
  • schnorr.py (the pure-python fallback code)
  • digitalbitbox.py

The plan is to now make ecc*.py and schnorr.py have a hard dependency on libsecp256k1 and remove the ecdsa dependency altogether.

This concludes backport of https://github.com/spesmilo/electrum/commit/16e4827e8c6db833b0a969351b73eb34d489681f

Depends on D16681

Test Plan

python test_runner.py

Activate Cash Fusion and wait for a succesfull fusion

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Mon, Aug 26, 15:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Aug 26, 15:16
PiRK requested review of this revision.Mon, Aug 26, 15:16
PiRK edited the summary of this revision. (Show Details)Mon, Aug 26, 15:17
Harbormaster completed remote builds in B30088: Diff 49354.Mon, Aug 26, 15:18
bytesofman mentioned this in D16665: [electrum] use python's standard library `secrets` for randrange.Mon, Aug 26, 21:10
PiRK updated this revision to Diff 49369.Tue, Aug 27, 07:06

rebase

Harbormaster completed remote builds in B30099: Diff 49369.Tue, Aug 27, 07:08
PiRK added inline comments.Tue, Aug 27, 08:29
electrum/electrumabc_plugins/fusion/pedersen.py
92 ↗(On Diff #49369)

this needs to be reworked a bit, I plan to no raise an error for point at infinity

PiRK planned changes to this revision.Tue, Aug 27, 08:29
PiRK updated this revision to Diff 49371.Tue, Aug 27, 09:25

properly handle point at infinity

Harbormaster completed remote builds in B30101: Diff 49371.Tue, Aug 27, 09:28
PiRK planned changes to this revision.Tue, Aug 27, 15:45

Use the constants GENERATOR and POINT_AT_INFINITY rather than functions.

PiRK updated this revision to Diff 49383.Wed, Aug 28, 06:58
PiRK retitled this revision from [electrum] use generator() and CURVE_ORDER from ecc module to [electrum] use GENERATOR and CURVE_ORDER from ecc module.
PiRK edited the summary of this revision. (Show Details)

rebase

Harbormaster completed remote builds in B30108: Diff 49383.Wed, Aug 28, 07:22
PiRK added a child revision: D16684: [electrum] also use libsecp256k1 for point addition.Thu, Aug 29, 09:39
PiRK updated this revision to Diff 49408.Thu, Aug 29, 09:40

rebase

Harbormaster completed remote builds in B30130: Diff 49408.Thu, Aug 29, 09:45
PiRK mentioned this in D16681: [electrum] properly handle point at infinity and point not on curve.Fri, Aug 30, 07:02
PiRK updated this revision to Diff 49416.Fri, Aug 30, 07:37

rebase

Harbormaster completed remote builds in B30136: Diff 49416.Fri, Aug 30, 07:40
Fabien accepted this revision.Fri, Aug 30, 20:28
This revision is now accepted and ready to land.Fri, Aug 30, 20:28
Closed by commit rABCcec785ad7fc4: [electrum] use GENERATOR and CURVE_ORDER from ecc module (authored by PiRK). · Explain WhyTue, Sep 3, 06:19
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCcec785ad7fc4: [electrum] use GENERATOR and CURVE_ORDER from ecc module.

Revision Contents
Changeset List

PathSize
electrum/
electrumabc/
40 lines
47 lines
tests/
11 lines
electrumabc_plugins/
fusion/
23 lines
5 lines
55 lines
tests/
7 lines
13 lines

Diff 49444

View Options

electrum/electrumabc/keystore.py

Loading...
View Options

electrum/electrumabc/schnorr.py

Loading...
View Options

electrum/electrumabc/tests/test_ecc.py

Loading...
View Options

electrum/electrumabc_plugins/fusion/encrypt.py

Loading...
View Options

electrum/electrumabc_plugins/fusion/fusion.py

Loading...
View Options

electrum/electrumabc_plugins/fusion/pedersen.py

Loading...
View Options

electrum/electrumabc_plugins/fusion/tests/test_pedersen.py

Loading...
View Options

electrum/electrumabc_plugins/fusion/util.py

Loading...