Page MenuHomePhabricator
Differential D16685

[electrum] grind ecdsa low R signature when using libsecp256k1
ClosedPublic
Actions

Authored by PiRK on Wed, Aug 28, 07:09.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABCb0d72c50a89b: [electrum] grind ecdsa low R signature when using libsecp256k1
Summary

This is a partial backport of electrum#5820

See also D4467
Note that Electrum ABC produces schnorr signatures for most transactions, so for most users this is not going to change much. It makes future backports a bit easier by adhering more closely to the Electrum code.

And I didn't backport the change in the pure python version of signing as this code is going to be dropped very soon.

Depends on D16684

Test Plan

python test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Wed, Aug 28, 07:09
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Aug 28, 07:09
PiRK requested review of this revision.Wed, Aug 28, 07:09
teamcity edited the summary of this revision. (Show Details)Wed, Aug 28, 07:09
PiRK updated this revision to Diff 49386.Wed, Aug 28, 07:15

restore coercing secret_exponent to int (see D14490)

PiRK added a child revision: D16686: [electrum] deduplicate the ECPrivkey.sign code.Wed, Aug 28, 07:24
Harbormaster completed remote builds in B30110: Diff 49385.Wed, Aug 28, 07:24
Harbormaster completed remote builds in B30111: Diff 49386.
bytesofman accepted this revision.Thu, Aug 29, 16:00
This revision is now accepted and ready to land.Thu, Aug 29, 16:00
PiRK updated this revision to Diff 49418.Fri, Aug 30, 07:40

rebase

Harbormaster completed remote builds in B30138: Diff 49418.Fri, Aug 30, 07:42
Closed by commit rABCb0d72c50a89b: [electrum] grind ecdsa low R signature when using libsecp256k1 (authored by PiRK). · Explain WhyTue, Sep 3, 06:19
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCb0d72c50a89b: [electrum] grind ecdsa low R signature when using libsecp256k1.

Revision Contents
Changeset List

PathSize
electrum/
electrumabc/
45 lines

Diff 49446

View Options

electrum/electrumabc/ecc_fast.py

Loading...