Page MenuHomePhabricator

[electrum] grind ecdsa low R signature when using libsecp256k1
ClosedPublic

Authored by PiRK on Aug 28 2024, 07:09.

Details

Summary

This is a partial backport of electrum#5820

See also D4467
Note that Electrum ABC produces schnorr signatures for most transactions, so for most users this is not going to change much. It makes future backports a bit easier by adhering more closely to the Electrum code.

And I didn't backport the change in the pure python version of signing as this code is going to be dropped very soon.

Depends on D16684

Test Plan

python test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Aug 28 2024, 07:09

restore coercing secret_exponent to int (see D14490)

This revision is now accepted and ready to land.Aug 29 2024, 16:00