Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC520813b84f7a: test: rename CTransaction .sha256 -> .txid_int for consistency

Summary

Note that we unfortunately can't use a scripted diff here, as the same
property name is also used for CBlockHeader/CBlock instances.

This is a partial backport of core#32421
https://github.com/bitcoin/bitcoin/pull/32421/commits/81af4334e8f903601dac503426eaccc1d3527f9c

Depends on D18714

Test Plan

ninja check-functional-extended

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 29 2025, 15:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 29 2025, 15:40

PiRK requested review of this revision.Sep 29 2025, 15:40

teamcity edited the summary of this revision. (Show Details)Sep 29 2025, 15:40

PiRK added a child revision: D18716: test: avoid unneeded txid hex -> integer conversions.Sep 29 2025, 15:42

Harbormaster completed remote builds in B34649: Diff 55947.Sep 29 2025, 16:00

missed one in abc_p2p_compactblocks

Harbormaster completed remote builds in B34652: Diff 55952.Sep 29 2025, 19:07

rebase

Harbormaster completed remote builds in B34656: Diff 55958.Sep 29 2025, 20:20

Fabien accepted this revision.Sep 30 2025, 07:25

This revision is now accepted and ready to land.Sep 30 2025, 07:25

rebase

Harbormaster completed remote builds in B34678: Diff 55991.Sep 30 2025, 09:09

Closed by commit rABC520813b84f7a: test: rename CTransaction .sha256 -> .txid_int for consistency (authored by PiRK). · Explain WhySep 30 2025, 09:48

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC520813b84f7a: test: rename CTransaction .sha256 -> .txid_int for consistency.

PiRK mentioned this in D18737: test: fix missing tx.hash -> tx.txid_hex and tx.sha256 -> tx.txid_int renamings.Sep 30 2025, 14:02

PiRK mentioned this in rABCeaee44f769d1: test: fix missing tx.hash -> tx.txid_hex and tx.sha256 -> tx.txid_int renamings.Sep 30 2025, 14:34

test: rename CTransaction .sha256 -> .txid_int for consistency
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 55998

test/functional/abc-mempool-coherence-on-activations.py

test/functional/abc-minimaldata.py

test/functional/abc-replay-protection.py

test/functional/abc-schnorr.py

test/functional/abc-schnorrmultisig.py

test/functional/abc-segwit-recovery.py

test/functional/abc-transaction-ordering.py

test/functional/abc_p2p_compactblocks.py

test/functional/abc_p2p_fullblocktest.py

test/functional/chronik_lokad_id_group.py

test/functional/chronik_plugin_groups.py

test/functional/chronik_plugins.py

test/functional/chronik_shutdown.py

test/functional/data/invalid_txs.py

test/functional/feature_assumevalid.py

test/functional/feature_bip68_sequence.py

test/functional/feature_block.py

test/functional/p2p_compactblocks.py

test/functional/p2p_invalid_tx.py

test/functional/p2p_tx_privacy.py

test/functional/test_framework/blocktools.py

test/functional/test_framework/messages.py

test/functional/test_framework/p2p.py

test: rename CTransaction .sha256 -> .txid_int for consistencyClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 55998

test/functional/abc-mempool-coherence-on-activations.py

test/functional/abc-minimaldata.py

test/functional/abc-replay-protection.py

test/functional/abc-schnorr.py

test/functional/abc-schnorrmultisig.py

test/functional/abc-segwit-recovery.py

test/functional/abc-transaction-ordering.py

test/functional/abc_p2p_compactblocks.py

test/functional/abc_p2p_fullblocktest.py

test/functional/chronik_lokad_id_group.py

test/functional/chronik_plugin_groups.py

test/functional/chronik_plugins.py

test/functional/chronik_shutdown.py

test/functional/data/invalid_txs.py

test/functional/feature_assumevalid.py

test/functional/feature_bip68_sequence.py

test/functional/feature_block.py

test/functional/p2p_compactblocks.py

test/functional/p2p_invalid_tx.py

test/functional/p2p_tx_privacy.py

test/functional/test_framework/blocktools.py

test/functional/test_framework/messages.py

test/functional/test_framework/p2p.py

test: rename CTransaction .sha256 -> .txid_int for consistency
ClosedPublic
Actions

Revision Contents
Changeset List