Paths

Table of Contentst

Differential D1920

[rpc] Deprecate estimatefee RPC
ClosedPublic
Actions

Authored by deadalnix on Oct 11 2018, 14:47.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING49ff27fedd36: [rpc] Deprecate estimatefee RPC
rABC49ff27fedd36: [rpc] Deprecate estimatefee RPC

Summary

Deprecate estimatefee in v0.16, for final removal in v0.17.

This commit introduces a phased removal of RPC methods. RPC method is
disabled by default in version x, but can be enabled by using the
-deprecatedrpc=<method> argument. RPC method is removed entirely in
version (x+1).

[rpc] [tests] Add deprecated RPC test

This is a backport of Core PR11031

Test Plan

make check
./test/functional/test_runner.py --extended

Diff Detail

Repository

rABC Bitcoin ABC

Branch

deprecaterpc

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3582
Build 5239: Bitcoin ABC Buildbot (legacy)
Build 5238: arc lint + arc unit

Event Timeline

deadalnix created this revision.Oct 11 2018, 14:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 11 2018, 14:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3582: Diff 5389.Oct 11 2018, 14:59

jasonbcox accepted this revision.Oct 12 2018, 21:37

This revision is now accepted and ready to land.Oct 12 2018, 21:37

Closed by commit rABC49ff27fedd36: [rpc] Deprecate estimatefee RPC (authored by John Newbery <john@johnnewbery.com>, committed by deadalnix). · Explain WhyOct 14 2018, 19:05

This revision was automatically updated to reflect the committed changes.

schancel mentioned this in D2012: [rpc] Undeprecate estimatefee.Nov 6 2018, 17:51

schancel mentioned this in rABCa4c86bad8530: [rpc] Undeprecate estimatefee.Nov 7 2018, 17:19

schancel mentioned this in rSTAGINGa4c86bad8530: [rpc] Undeprecate estimatefee.Nov 30 2018, 21:30

Revision Contents
Changeset List

Path

Size

src/

init.cpp

3 lines

rpc/

10 lines

2 lines

2 lines

8 lines

test/

functional/

deprecated_rpc.py

26 lines

timing.json

154 lines

Diff 5389

View Options

src/init.cpp

View Options

src/rpc/mining.cpp

View Options

src/rpc/protocol.h

View Options

src/rpc/server.h

View Options

src/rpc/server.cpp

View Options

test/functional/deprecated_rpc.py

View Options

test/functional/timing.json

[rpc] Deprecate estimatefee RPCClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 5389

src/init.cpp

src/rpc/mining.cpp

src/rpc/protocol.h

src/rpc/server.h

src/rpc/server.cpp

test/functional/deprecated_rpc.py

test/functional/timing.json

[rpc] Deprecate estimatefee RPC
ClosedPublic
Actions

Revision Contents
Changeset List