Page MenuHomePhabricator
Differential D1945

Refactor FindMostWorkChain
ClosedPublic
Actions

Authored by deadalnix on Oct 20 2018, 15:23.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING4636385d7fa0: Refactor FindMostWorkChain
rABC4636385d7fa0: Refactor FindMostWorkChain
Summary

Chaneg the flow a bit to reduce nesting, and add a few comments.

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
findmostwork
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3628
Build 5331: Bitcoin ABC Buildbot (legacy)
Build 5330: arc lint + arc unit

Event Timeline

deadalnix created this revision.Oct 20 2018, 15:23
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 20 2018, 15:23
teamcity added a subscriber: teamcity.Oct 20 2018, 15:25

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B3628: Diff 5456!Oct 20 2018, 15:34
teamcity added a comment.Oct 20 2018, 15:34

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

deadalnix updated this revision to Diff 5457.Oct 20 2018, 15:40

Refactor to change fInvalidAncestor into hasValidAncestor to avoid double negations.

teamcity added a comment.Oct 20 2018, 15:42

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix mentioned this in D1942: Track the best parked chain tip..Oct 20 2018, 15:43
deadalnix added a child revision: D1942: Track the best parked chain tip..Oct 20 2018, 15:45
teamcity added a comment.Oct 20 2018, 15:50

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3629: Diff 5457.Oct 20 2018, 15:50
jasonbcox accepted this revision.Oct 20 2018, 16:31
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/validation.cpp
2449 ↗(On Diff #5457)

Seems like this spinning forever could be error-prone despite the comment at the top of this function. Doesn't need to be part of this diff, but we should have some sort of cycle detection in place to fail out if this appears to spin forever.

This revision is now accepted and ready to land.Oct 20 2018, 16:31
Closed by commit rABC4636385d7fa0: Refactor FindMostWorkChain (authored by deadalnix). · Explain WhyOct 20 2018, 18:53
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
65 lines

Diff 5456

View Options

src/validation.cpp

Loading...