Differential D1980

Add address filtering to listreceivedbyaddress
ClosedPublic
Actions

Authored by schancel on Oct 29 2018, 22:35.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING49a6e572ef41: Add address filtering to listreceivedbyaddress
rABC49a6e572ef41: Add address filtering to listreceivedbyaddress

Summary

Add address filtering to listreceivedbyaddress

Backport Core PR9991

Depends on D1984

Test Plan

make check && ./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr9991

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3712
Build 5499: Bitcoin ABC Buildbot (legacy)
Build 5498: arc lint + arc unit

Event Timeline

schancel created this revision.Oct 29 2018, 22:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 29 2018, 22:35

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B3712: Diff 5572.Oct 29 2018, 22:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

schancel edited the summary of this revision. (Show Details)Oct 29 2018, 23:44

schancel added a parent revision: D1984: [Part 2 of 2] [wallet] getreceivedbyaddress should return error if address is not mine.

schancel added a child revision: D1986: Rename account to label where appropriate.Oct 29 2018, 23:59

jasonbcox accepted this revision.Oct 30 2018, 00:25

This revision is now accepted and ready to land.Oct 30 2018, 00:25

Closed by commit rABC49a6e572ef41: Add address filtering to listreceivedbyaddress (authored by Jeremy Rubin <jeremy.l.rubin@gmail.com>, committed by schancel). · Explain WhyOct 30 2018, 00:30

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

rpc/

client.cpp

1 line

wallet/

rpcwallet.cpp

57 lines

test/

functional/

receivedby.py

46 lines

Diff 5572

View Options

src/rpc/client.cpp

View Options

src/wallet/rpcwallet.cpp

View Options

test/functional/receivedby.py

Add address filtering to listreceivedbyaddressClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 5572

src/rpc/client.cpp

src/wallet/rpcwallet.cpp

test/functional/receivedby.py

Add address filtering to listreceivedbyaddress
ClosedPublic
Actions

Revision Contents
Changeset List