Page MenuHomePhabricator

Fixed bug in UnwindBlock where child blocks do not have proper parent flags set
ClosedPublic

Authored by jasonbcox on Oct 30 2018, 21:05.

Details

Summary

Fixed a typo introduced in my fix from 4a9b35aa3

Important note: There is unintuitive behavior now documented in the test in the form of NOTE comments. The order of calling parkblock and invalidateblock impacts the chaintip status.

Test Plan

test_runner.py abc-parkedchain
The new test fails without the fix and passes with it.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
parked
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3726
Build 5527: Bitcoin ABC Buildbot (legacy)
Build 5526: arc lint + arc unit

Event Timeline

Make expected state more explicit in order to not accidentally hide bugs

test/functional/abc-parkedchain.py
20

will remove. forgot to remove when debugging

jasonbcox edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Nov 1 2018, 01:24
This revision was automatically updated to reflect the committed changes.