Page MenuHomePhabricator
Differential D1987

Fixed bug in UnwindBlock where child blocks do not have proper parent flags set
ClosedPublic
Actions

Authored by jasonbcox on Oct 30 2018, 21:05.

Details

Reviewers
deadalnix
schancel
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING3cc9d160357a: Fixed bug in UnwindBlock where child blocks do not have proper parent flags set
rABC3cc9d160357a: Fixed bug in UnwindBlock where child blocks do not have proper parent flags set
Summary

Fixed a typo introduced in my fix from 4a9b35aa3

Important note: There is unintuitive behavior now documented in the test in the form of NOTE comments. The order of calling parkblock and invalidateblock impacts the chaintip status.

Test Plan

test_runner.py abc-parkedchain
The new test fails without the fix and passes with it.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
arcpatch-D1987
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3737
Build 5549: Bitcoin ABC Buildbot (legacy)
Build 5548: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Oct 30 2018, 21:05
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 30 2018, 21:05
teamcity added a subscriber: teamcity.Oct 30 2018, 21:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox edited the summary of this revision. (Show Details)Oct 30 2018, 21:08
teamcity added a comment.Oct 30 2018, 21:15

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3724: Diff 5590.Oct 30 2018, 21:15
jasonbcox updated this revision to Diff 5591.Oct 30 2018, 21:42

Fixed comment

teamcity added a comment.Oct 30 2018, 21:44

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B3725: Diff 5591!Oct 30 2018, 21:53
teamcity added a comment.Oct 30 2018, 21:53

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

jasonbcox updated this revision to Diff 5592.Oct 30 2018, 22:10

Make expected state more explicit in order to not accidentally hide bugs

teamcity added a comment.Oct 30 2018, 22:11

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Oct 30 2018, 22:19

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3726: Diff 5592.Oct 30 2018, 22:19
jasonbcox added inline comments.Oct 30 2018, 23:41
test/functional/abc-parkedchain.py
20 ↗(On Diff #5592)

will remove. forgot to remove when debugging

jasonbcox updated this revision to Diff 5607.Nov 1 2018, 00:05

Rebase and fix comments

jasonbcox marked an inline comment as done.Nov 1 2018, 00:05
jasonbcox edited the summary of this revision. (Show Details)
teamcity added a comment.Nov 1 2018, 00:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 1 2018, 00:15

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3737: Diff 5607.Nov 1 2018, 00:15
deadalnix accepted this revision.Nov 1 2018, 01:24
This revision is now accepted and ready to land.Nov 1 2018, 01:24
Fabien accepted this revision.Nov 1 2018, 12:46
Closed by commit rABC3cc9d160357a: Fixed bug in UnwindBlock where child blocks do not have proper parent flags set (authored by jasonbcox). · Explain WhyNov 1 2018, 16:59
This revision was automatically updated to reflect the committed changes.
jasonbcox added a child revision: D1977: Merge #11531: Check that new headers are not a descendant of an invalid block (more effeciently).Nov 1 2018, 18:48

Revision Contents
Changeset List

PathSize
src/
7 lines
test/
functional/
62 lines

Diff 5607

View Options

src/validation.cpp

Loading...
View Options

test/functional/abc-parkedchain.py

Loading...