Page MenuHomePhabricator
Differential D2001

[qa] Improve wallet-accounts test
ClosedPublic
Actions

Authored by schancel on Nov 2 2018, 22:19.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING0d78d3bac38d: [qa] Improve wallet-accounts test
rABC0d78d3bac38d: [qa] Improve wallet-accounts test
Summary

Add comments and

  • Verify sending to a account causes getaccountaddress to generate new addresses.
  • Verify sending to a account causes getreceivedbyaccount to return amount received.
  • Verify ways setaccount updates the accounts of existing addresses.

Backport of Core PR11552

Test Plan
./test/functional/test_runner.py wallet-accounts.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

schancel created this revision.Nov 2 2018, 22:19
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 2 2018, 22:19
teamcity added a subscriber: teamcity.Nov 2 2018, 22:21

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix accepted this revision.Nov 2 2018, 22:24
This revision is now accepted and ready to land.Nov 2 2018, 22:24
schancel mentioned this in D1986: Rename account to label where appropriate.Nov 2 2018, 22:25
jasonbcox requested changes to this revision.Nov 2 2018, 22:25
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
test/functional/wallet-accounts.py
216 ↗(On Diff #5631)

Needs backport information in the summary

This revision now requires changes to proceed.Nov 2 2018, 22:25
schancel edited the summary of this revision. (Show Details)Nov 2 2018, 22:27
schancel marked an inline comment as done.
schancel added a child revision: D1986: Rename account to label where appropriate.
teamcity added a comment.Nov 2 2018, 22:28

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox accepted this revision.Nov 2 2018, 22:29
This revision is now accepted and ready to land.Nov 2 2018, 22:29
Harbormaster completed remote builds in B3754: Diff 5631.Nov 2 2018, 22:30
schancel added a child revision: D2002: Disallow using addresses in createmultisig.Nov 2 2018, 22:36
Closed by commit rABC0d78d3bac38d: [qa] Improve wallet-accounts test (authored by Russell Yanofsky <russ@yanofsky.org>, committed by schancel). · Explain WhyNov 5 2018, 19:55
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
test/
functional/
142 lines

Diff 5647

View Options

test/functional/wallet-accounts.py

Loading...