Page MenuHomePhabricator

Compute max generated block size depending on UAHF activation
ClosedPublic

Authored by deadalnix on Jun 15 2017, 13:43.

Details

Summary

We don't want to allow block more than 1MB to be generated before UAHF activation.

Test Plan

Added tests that check the generated block size before and after activation.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
maxgeneratedblocksize
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 314
Build 314: arc lint + arc unit

Event Timeline

src/test/miner_tests.cpp
691 ↗(On Diff #496)

outselves -> ourselves

698 ↗(On Diff #496)

Caps (-> Test ...)

706 ↗(On Diff #496)

why not use LEGACY_CAP instead of ONE_MEGABYTE - 1000 here?

src/test/miner_tests.cpp
706 ↗(On Diff #496)

Because we don't hit the ceiling yet.

This revision is now accepted and ready to land.Jun 16 2017, 12:00
This revision was automatically updated to reflect the committed changes.