Page MenuHomePhabricator
Differential D206

Compute max generated block size depending on UAHF activation
ClosedPublic
Actions

Authored by deadalnix on Jun 15 2017, 13:43.

Details

Reviewers
freetrader
sickpig
kyuupichan
awemany
Group Reviewers
Restricted Project
Commits
rSTAGING2e062570e814: Compute max generated block size depending on UAHF activation
rABC2e062570e814: Compute max generated block size depending on UAHF activation
Summary

We don't want to allow block more than 1MB to be generated before UAHF activation.

Test Plan

Added tests that check the generated block size before and after activation.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
maxgeneratedblocksize
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 314
Build 314: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jun 15 2017, 13:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 15 2017, 13:43
deadalnix added a child revision: D207: Change default for excessive block size and generated block size.Jun 15 2017, 14:26
freetrader added inline comments.Jun 16 2017, 11:35
src/test/miner_tests.cpp
691 ↗(On Diff #496)

outselves -> ourselves

698 ↗(On Diff #496)

Caps (-> Test ...)

706 ↗(On Diff #496)

why not use LEGACY_CAP instead of ONE_MEGABYTE - 1000 here?

deadalnix added inline comments.Jun 16 2017, 11:41
src/test/miner_tests.cpp
706 ↗(On Diff #496)

Because we don't hit the ceiling yet.

deadalnix updated this revision to Diff 513.Jun 16 2017, 11:42

Fix typos

Harbormaster completed remote builds in B314: Diff 513.Jun 16 2017, 11:42
freetrader accepted this revision.Jun 16 2017, 12:00
This revision is now accepted and ready to land.Jun 16 2017, 12:00
Closed by commit rABC2e062570e814: Compute max generated block size depending on UAHF activation (authored by deadalnix, committed by deadalnix). · Explain WhyJun 16 2017, 12:09
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
6 lines
40 lines
policy/
4 lines
test/
68 lines
4 lines
10 lines

Diff 513

View Options

src/miner.h

Loading...
View Options

src/miner.cpp

Loading...
View Options

src/policy/policy.h

Loading...
View Options

src/test/miner_tests.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...