Page MenuHomePhabricator
Differential D2127

Remove unused parameter for AcceptBlock
ClosedPublic
Actions

Authored by schancel on Nov 24 2018, 20:33.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING3b248bbe567c: Remove unused parameter for AcceptBlock
rABC3b248bbe567c: Remove unused parameter for AcceptBlock
Summary

As per title. This param is a null or dummy parameter everywhere AcceptBlock is used.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
accept-block-param (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4101
Build 6273: Bitcoin ABC Buildbot (legacy)
Build 6272: arc lint + arc unit

Event Timeline

schancel created this revision.Nov 24 2018, 20:33
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 24 2018, 20:33
schancel edited the summary of this revision. (Show Details)Nov 24 2018, 20:33
teamcity added a subscriber: teamcity.Nov 24 2018, 20:35

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 24 2018, 20:44

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4101: Diff 6078.Nov 24 2018, 20:44
jasonbcox requested changes to this revision.Nov 24 2018, 23:49
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/validation.cpp
3689

Remove comment

This revision now requires changes to proceed.Nov 24 2018, 23:49
schancel updated this revision to Diff 6081.Nov 25 2018, 00:07

Fix feedback

teamcity added a comment.Nov 25 2018, 00:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 25 2018, 00:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4104: Diff 6081.Nov 25 2018, 00:16
jasonbcox accepted this revision.Nov 25 2018, 00:42
This revision is now accepted and ready to land.Nov 25 2018, 00:42
Closed by commit rABC3b248bbe567c: Remove unused parameter for AcceptBlock (authored by schancel). · Explain WhyNov 25 2018, 09:40
This revision was automatically updated to reflect the committed changes.
PiRK mentioned this in D13913: index: Commit DB_MUHASH and DB_BEST_BLOCK to disk together.May 17 2023, 16:16
PiRK mentioned this in rABC9f3a925b490d: index: Commit DB_MUHASH and DB_BEST_BLOCK to disk together.May 18 2023, 07:59

Revision Contents
Changeset List

PathSize
src/
19 lines

Diff 6078

View Options

src/validation.cpp

Loading...