Page MenuHomePhabricator

Remove unused parameter for AcceptBlock
ClosedPublic

Authored by schancel on Nov 24 2018, 20:33.

Details

Summary

As per title. This param is a null or dummy parameter everywhere AcceptBlock is used.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
accept-block-param (branched from master)
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 4104
Build 6279: Bitcoin ABC Buildbot (legacy)
Build 6278: arc lint + arc unit

Event Timeline

schancel created this revision.Nov 24 2018, 20:33
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 24 2018, 20:33
schancel edited the summary of this revision. (Show Details)Nov 24 2018, 20:33
jasonbcox requested changes to this revision.Nov 24 2018, 23:49
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/validation.cpp
3689 ↗(On Diff #6078)

Remove comment

This revision now requires changes to proceed.Nov 24 2018, 23:49
schancel updated this revision to Diff 6081.Nov 25 2018, 00:07

Fix feedback

jasonbcox accepted this revision.Nov 25 2018, 00:42
This revision is now accepted and ready to land.Nov 25 2018, 00:42
This revision was automatically updated to reflect the committed changes.