Page MenuHomePhabricator

[Part 2 of 4] [qa] De-globalize port seeding
Needs ReviewPublic

Authored by schancel on Fri, Nov 30, 21:41.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Summary

This commit makes initialize_datadir take it's port parameters
instead of inferring them from global state by itself.

This will enable removing the global p2p_port and rpc_port
functions in our next commit.

Depends on D2159

Test Plan
./test/functional/test_runner.py --extended

Diff Detail

Event Timeline

schancel created this revision.Fri, Nov 30, 21:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Nov 30, 21:41
schancel retitled this revision from [Part 1 of 3] [qa] De-globalize port seeding to [Part 2 of 3] [qa] De-globalize port seeding.Fri, Nov 30, 21:48
schancel updated this revision to Diff 6216.Fri, Nov 30, 22:58

Rebase and fix extraneous changes

schancel retitled this revision from [Part 2 of 3] [qa] De-globalize port seeding to [Part 2 of 4] [qa] De-globalize port seeding.
schancel updated this revision to Diff 6226.Sat, Dec 1, 21:58

Rebase