Page MenuHomePhabricator

[Part 2 of 4] [qa] De-globalize port seeding
AbandonedPublic

Authored by schancel on Nov 30 2018, 21:41.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Summary

This commit makes initialize_datadir take it's port parameters
instead of inferring them from global state by itself.

This will enable removing the global p2p_port and rpc_port
functions in our next commit.

Depends on D2159

Test Plan
./test/functional/test_runner.py --extended

Diff Detail

Event Timeline

schancel created this revision.Nov 30 2018, 21:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 30 2018, 21:41
schancel retitled this revision from [Part 1 of 3] [qa] De-globalize port seeding to [Part 2 of 3] [qa] De-globalize port seeding.Nov 30 2018, 21:48
schancel updated this revision to Diff 6216.Nov 30 2018, 22:58

Rebase and fix extraneous changes

schancel retitled this revision from [Part 2 of 3] [qa] De-globalize port seeding to [Part 2 of 4] [qa] De-globalize port seeding.
schancel updated this revision to Diff 6226.Dec 1 2018, 21:58

Rebase

jasonbcox accepted this revision.Jan 2 2019, 18:44
This revision is now accepted and ready to land.Jan 2 2019, 18:44
jasonbcox requested changes to this revision.Jan 2 2019, 18:45

Noticed harbormaster isn't passing.

This revision now requires changes to proceed.Jan 2 2019, 18:45
schancel abandoned this revision.Sun, Mar 17, 04:32