Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Summary

Finally, remove the p2p_port and rpc_port global functions,
and the global PortSeed.n state.

Depends on D2165

Test Plan

./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4223
Build 6512: Bitcoin ABC Buildbot (legacy)
Build 6511: arc lint + arc unit

Event Timeline

schancel created this revision.Nov 30 2018, 21:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 30 2018, 21:47

Herald added a reviewer: deadalnix. · View Herald Transcript

Remove extraneous whitespace

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

schancel retitled this revision from [Part 3 of 3] De-globalize port seeding to [Part 3 of 3] [qa] De-globalize port seeding.Nov 30 2018, 21:52

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B4205: Diff 6210!Nov 30 2018, 21:59

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B4206: Diff 6211!Nov 30 2018, 22:00

Rebase and fix extraneous changes

schancel edited the summary of this revision. (Show Details)Nov 30 2018, 23:01

schancel added a parent revision: D2165: [Part 3 of 4] [qa] De-globalize port seeding.

schancel removed a parent revision: D2163: [Part 2 of 4] [qa] De-globalize port seeding.

schancel retitled this revision from [Part 3 of 3] [qa] De-globalize port seeding to [Part 4 of 4] [qa] De-globalize port seeding.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B4213: Diff 6218!Nov 30 2018, 23:15

Rebase

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B4220: Diff 6225!Dec 1 2018, 22:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B4223: Diff 6228!Dec 1 2018, 22:12

Please check harbormaster failure

This revision now requires changes to proceed.Jan 2 2019, 18:46

schancel abandoned this revision.Mar 17 2019, 04:32

[Part 4 of 4] [qa] De-globalize port seeding
AbandonedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 6228

test/functional/abc-p2p-compactblocks.py

test/functional/assumevalid.py

test/functional/bip65-cltv-p2p.py

test/functional/bipdersig-p2p.py

test/functional/example_test.py

test/functional/maxuploadtarget.py

test/functional/net.py

test/functional/p2p-acceptblock.py

test/functional/p2p-compactblocks.py

test/functional/p2p-feefilter.py

test/functional/p2p-leaktests.py

test/functional/p2p-mempool.py

test/functional/p2p-timeouts.py

test/functional/rpcbind_test.py

test/functional/sendheaders.py

test/functional/test_framework/comptool.py

test/functional/test_framework/test_framework.py

test/functional/test_framework/test_node.py

test/functional/test_framework/util.py

[Part 4 of 4] [qa] De-globalize port seedingAbandonedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 6228

test/functional/abc-p2p-compactblocks.py

test/functional/assumevalid.py

test/functional/bip65-cltv-p2p.py

test/functional/bipdersig-p2p.py

test/functional/example_test.py

test/functional/maxuploadtarget.py

test/functional/net.py

test/functional/p2p-acceptblock.py

test/functional/p2p-compactblocks.py

test/functional/p2p-feefilter.py

test/functional/p2p-leaktests.py

test/functional/p2p-mempool.py

test/functional/p2p-timeouts.py

test/functional/rpcbind_test.py

test/functional/sendheaders.py

test/functional/test_framework/comptool.py

test/functional/test_framework/test_framework.py

test/functional/test_framework/test_node.py

test/functional/test_framework/util.py

[Part 4 of 4] [qa] De-globalize port seeding
AbandonedPublic
Actions

Revision Contents
Changeset List