Page MenuHomePhabricator
Differential D2164

[Part 4 of 4] [qa] De-globalize port seeding
AbandonedPublic
Actions

Authored by schancel on Nov 30 2018, 21:47.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Summary

Finally, remove the p2p_port and rpc_port global functions,
and the global PortSeed.n state.

Depends on D2165

Test Plan
./test/functional/test_runner.py

Diff Detail

Event Timeline

schancel created this revision.Nov 30 2018, 21:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 30 2018, 21:47
Herald added a reviewer: deadalnix. · View Herald Transcript
schancel updated this revision to Diff 6211.Nov 30 2018, 21:48

Remove extraneous whitespace

teamcity added a subscriber: teamcity.Nov 30 2018, 21:50

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 30 2018, 21:51

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

schancel retitled this revision from [Part 3 of 3] De-globalize port seeding to [Part 3 of 3] [qa] De-globalize port seeding.Nov 30 2018, 21:52
teamcity added a comment.Nov 30 2018, 21:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B4205: Diff 6210!Nov 30 2018, 21:59
teamcity added a comment.Nov 30 2018, 21:59

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B4206: Diff 6211!Nov 30 2018, 22:00
schancel updated this revision to Diff 6218.Nov 30 2018, 23:01

Rebase and fix extraneous changes

schancel edited the summary of this revision. (Show Details)Nov 30 2018, 23:01
schancel added a parent revision: D2165: [Part 3 of 4] [qa] De-globalize port seeding.
schancel removed a parent revision: D2163: [Part 2 of 4] [qa] De-globalize port seeding.
schancel retitled this revision from [Part 3 of 3] [qa] De-globalize port seeding to [Part 4 of 4] [qa] De-globalize port seeding.
teamcity added a comment.Nov 30 2018, 23:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 30 2018, 23:14

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B4213: Diff 6218!Nov 30 2018, 23:15
schancel updated this revision to Diff 6225.Dec 1 2018, 21:58

Rebase

schancel updated this revision to Diff 6228.Dec 1 2018, 21:59

Rebase

teamcity added a comment.Dec 1 2018, 22:00

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Dec 1 2018, 22:03

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Dec 1 2018, 22:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B4220: Diff 6225!Dec 1 2018, 22:08
teamcity added a comment.Dec 1 2018, 22:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B4223: Diff 6228!Dec 1 2018, 22:12
jasonbcox requested changes to this revision.Jan 2 2019, 18:45
jasonbcox added a subscriber: jasonbcox.

Please check harbormaster failure

This revision now requires changes to proceed.Jan 2 2019, 18:46
schancel abandoned this revision.Mar 17 2019, 04:32

Revision Contents
Changeset List

Diff 6218

View Options

test/functional/abc-p2p-compactblocks.py

Loading...
View Options

test/functional/assumevalid.py

Loading...
View Options

test/functional/bip65-cltv-p2p.py

Loading...
View Options

test/functional/bipdersig-p2p.py

Loading...
View Options

test/functional/example_test.py

Loading...
View Options

test/functional/maxuploadtarget.py

Loading...
View Options

test/functional/net.py

Loading...
View Options

test/functional/p2p-acceptblock.py

Loading...
View Options

test/functional/p2p-compactblocks.py

Loading...
View Options

test/functional/p2p-feefilter.py

Loading...
View Options

test/functional/p2p-leaktests.py

Loading...
View Options

test/functional/p2p-mempool.py

Loading...
View Options

test/functional/p2p-timeouts.py

Loading...
View Options

test/functional/proxy_test.py

Loading...
View Options

test/functional/rpcbind_test.py

Loading...
View Options

test/functional/sendheaders.py

Loading...
View Options

test/functional/test_framework/comptool.py

Loading...
View Options

test/functional/test_framework/test_framework.py

Loading...
View Options

test/functional/test_framework/test_node.py

Loading...
View Options

test/functional/test_framework/util.py

Loading...