Page MenuHomePhabricator

[Part 4 of 4] [qa] De-globalize port seeding
AbandonedPublic

Authored by schancel on Nov 30 2018, 21:47.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Summary

Finally, remove the p2p_port and rpc_port global functions,
and the global PortSeed.n state.

Depends on D2165

Test Plan
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
deglobalize-port
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 4220
Build 6506: Bitcoin ABC Teamcity Staging
Build 6505: arc lint + arc unit

Event Timeline

schancel created this revision.Nov 30 2018, 21:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 30 2018, 21:47
schancel updated this revision to Diff 6211.Nov 30 2018, 21:48

Remove extraneous whitespace

schancel retitled this revision from [Part 3 of 3] De-globalize port seeding to [Part 3 of 3] [qa] De-globalize port seeding.Nov 30 2018, 21:52
schancel updated this revision to Diff 6218.Nov 30 2018, 23:01

Rebase and fix extraneous changes

schancel edited the summary of this revision. (Show Details)Nov 30 2018, 23:01
schancel retitled this revision from [Part 3 of 3] [qa] De-globalize port seeding to [Part 4 of 4] [qa] De-globalize port seeding.
schancel updated this revision to Diff 6225.Dec 1 2018, 21:58

Rebase

schancel updated this revision to Diff 6228.Dec 1 2018, 21:59

Rebase

jasonbcox requested changes to this revision.Jan 2 2019, 18:45
jasonbcox added a subscriber: jasonbcox.

Please check harbormaster failure

This revision now requires changes to proceed.Jan 2 2019, 18:46
schancel abandoned this revision.Sun, Mar 17, 04:32