Page MenuHomePhabricator

[Part 4 of 4] [qa] De-globalize port seeding
AbandonedPublic

Authored by schancel on Nov 30 2018, 21:47.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Summary

Finally, remove the p2p_port and rpc_port global functions,
and the global PortSeed.n state.

Depends on D2165

Test Plan
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
deglobalize-port
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4220
Build 6506: Bitcoin ABC Buildbot (legacy)
Build 6505: arc lint + arc unit

Event Timeline

Remove extraneous whitespace

schancel retitled this revision from [Part 3 of 3] De-globalize port seeding to [Part 3 of 3] [qa] De-globalize port seeding.Nov 30 2018, 21:52

Rebase and fix extraneous changes

schancel retitled this revision from [Part 3 of 3] [qa] De-globalize port seeding to [Part 4 of 4] [qa] De-globalize port seeding.
jasonbcox requested changes to this revision.Jan 2 2019, 18:45
jasonbcox added a subscriber: jasonbcox.

Please check harbormaster failure

This revision now requires changes to proceed.Jan 2 2019, 18:46