The documentation seemed out-of-date. Updated based on the output from
running the command: src/bench/bench_bitcoin
Details
Details
- Reviewers
Fabien jasonbcox deadalnix - Group Reviewers
Restricted Project - Maniphest Tasks
- T59: Change branding and documentation from Bitcoin Core to Bitcoin ABC
- Commits
- rSTAGING5075f4b11b98: Update doc/benchmarking.md
rABC5075f4b11b98: Update doc/benchmarking.md
run src/bench/bench_bitcoin and inspect output. check that documentation
matched test output.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- T59
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 4334 Build 6733: Bitcoin ABC Buildbot (legacy) Build 6732: arc lint + arc unit
Event Timeline
Comment Actions
I'm a bit unsure about the list of what's included, and what is still needed.
@Fabien, @jasonbcox Could you guys help double-check the list for me, to see if I missed something or mis-interpreted the benchmark output?
| doc/benchmarking.md | ||
|---|---|---|
| 29 ↗ | (On Diff #6338) | From my understanding the actual mempool benchmark does not cover everything that could be benchmarked, thus the Memory pool mention can be left in place. @jasonbcox can you confirm this ? |