Use nullptr instead of zero (0) as the null pointer constant
ClosedPublic
Actions

Authored by Fabien on Dec 19 2018, 10:36.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING852b274c442a: Use nullptr instead of zero (0) as the null pointer constant
rABC852b274c442a: Use nullptr instead of zero (0) as the null pointer constant

Summary

Backport of core PR10645

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR10645

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4327
Build 6719: Bitcoin ABC Buildbot (legacy)
Build 6718: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 19 2018, 10:36

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 19 2018, 10:36

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Fabien added a child revision: D2207: Declare single-argument (non-converting) constructors "explicit".Dec 19 2018, 10:45

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4327: Diff 6357.Dec 19 2018, 18:08

jasonbcox accepted this revision.Dec 20 2018, 00:05

This revision is now accepted and ready to land.Dec 20 2018, 00:05

Fabien mentioned this in D2207: Declare single-argument (non-converting) constructors "explicit".Dec 20 2018, 13:38

Closed by commit rABC852b274c442a: Use nullptr instead of zero (0) as the null pointer constant (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by Fabien). · Explain WhyDec 21 2018, 12:02

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

httprpc.cpp

4 lines

httpserver.cpp

14 lines

support/

lockedpool.h

2 lines

torcontrol.cpp

6 lines

validation.h

2 lines

wallet/

rpcwallet.cpp

4 lines

wallet.cpp

6 lines

walletdb.cpp

4 lines

zmq/

zmqabstractnotifier.h

2 lines

zmqnotificationinterface.cpp

2 lines

zmqpublishnotifier.cpp

4 lines

Diff 6357

View Options

src/httprpc.cpp

View Options

src/httpserver.cpp

View Options

src/support/lockedpool.h

View Options

src/torcontrol.cpp

View Options

src/validation.h

View Options

src/wallet/rpcwallet.cpp

View Options

src/wallet/wallet.cpp

View Options

src/wallet/walletdb.cpp

View Options

src/zmq/zmqabstractnotifier.h

View Options

src/zmq/zmqnotificationinterface.cpp

View Options

src/zmq/zmqpublishnotifier.cpp

Use nullptr instead of zero (0) as the null pointer constantClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 6357

src/httprpc.cpp

src/httpserver.cpp

src/support/lockedpool.h

src/torcontrol.cpp

src/validation.h

src/wallet/rpcwallet.cpp

src/wallet/wallet.cpp

src/wallet/walletdb.cpp

src/zmq/zmqabstractnotifier.h

src/zmq/zmqnotificationinterface.cpp

src/zmq/zmqpublishnotifier.cpp

Use nullptr instead of zero (0) as the null pointer constant
ClosedPublic
Actions

Revision Contents
Changeset List