Page MenuHomePhabricator
Differential D2246

Stop always storing blocks from whitelisted peers
ClosedPublic
Actions

Authored by jasonbcox on Jan 1 2019, 01:41.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGc3f4936b0453: Stop always storing blocks from whitelisted peers
rABCc3f4936b0453: Stop always storing blocks from whitelisted peers
Summary

There is no reason to wish to store blocks on disk always just
because a peer is whitelisted. This appears to be a historical
quirk to avoid breaking things when the accept limits were added.

Partial backport of Core PR 11531 (3d9c70ca0f):
https://github.com/bitcoin/bitcoin/pull/11531/commits/3d9c70ca0fd5d42f31114b689714af1825f0ed30

Test Plan

test_runner.py p2p-acceptblock

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr11531-2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4394
Build 6853: Bitcoin ABC Buildbot (legacy)
Build 6852: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jan 1 2019, 01:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 1 2019, 01:41
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 1 2019, 01:41

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 1 2019, 01:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4394: Diff 6477.Jan 1 2019, 01:49
deadalnix accepted this revision.Jan 1 2019, 14:59
This revision is now accepted and ready to land.Jan 1 2019, 14:59
Closed by commit rABCc3f4936b0453: Stop always storing blocks from whitelisted peers (authored by Matt Corallo <git@bluematt.me>, committed by jasonbcox). · Explain WhyJan 3 2019, 18:27
This revision was automatically updated to reflect the committed changes.
jasonbcox mentioned this in D2252: Revert "Stop always storing blocks from whitelisted peers".Jan 3 2019, 22:47
jasonbcox mentioned this in rABC9bc3e8965f82: Revert "Stop always storing blocks from whitelisted peers".Jan 3 2019, 23:06
jasonbcox mentioned this in rSTAGING9bc3e8965f82: Revert "Stop always storing blocks from whitelisted peers".Jan 20 2019, 23:54
jasonbcox added a comment.Mar 5 2019, 00:35

Progress towards T456

jasonbcox mentioned this in D1977: Merge #11531: Check that new headers are not a descendant of an invalid block (more effeciently).Mar 5 2019, 00:36

Revision Contents
Changeset List

PathSize
src/
6 lines

Diff 6477

View Options

src/net_processing.cpp

Loading...