Page MenuHomePhabricator
Differential D2321

Document assumptions that are being made to avoid NULL pointer dereferences
ClosedPublic
Actions

Authored by jasonbcox on Jan 15 2019, 22:43.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING678d6237bb16: Document assumptions that are being made to avoid NULL pointer dereferences
rABC678d6237bb16: Document assumptions that are being made to avoid NULL pointer dereferences
Summary

Backport of Core PR11132
Completes T519
Depends on D2320

Test Plan

ninja check
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr11132
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4537
Build 7137: Bitcoin ABC Buildbot (legacy)
Build 7136: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Jan 15 2019, 22:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 15 2019, 22:43
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 15 2019, 22:45

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 15 2019, 22:53

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4537: Diff 6685.Jan 15 2019, 22:53
deadalnix requested changes to this revision.Jan 16 2019, 00:40

ninja does not support the whole range of feature that make does. Please do test the make build.

Use PR11132 without spaces so it can be grepped for.

This revision now requires changes to proceed.Jan 16 2019, 00:40
jasonbcox edited the summary of this revision. (Show Details)Jan 16 2019, 01:15
jasonbcox requested review of this revision.Jan 17 2019, 00:42
jasonbcox edited the test plan for this revision. (Show Details)
deadalnix accepted this revision.Jan 17 2019, 00:53
This revision is now accepted and ready to land.Jan 17 2019, 00:53
Closed by commit rABC678d6237bb16: Document assumptions that are being made to avoid NULL pointer dereferences (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by jasonbcox). · Explain WhyJan 17 2019, 17:17
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
qt/
2 lines
2 lines
wallet/
4 lines

Diff 6685

View Options

src/qt/walletframe.cpp

Loading...
View Options

src/validation.cpp

Loading...
View Options

src/wallet/wallet.cpp

Loading...