Page MenuHomePhabricator
Differential D234

Format addrman.{h|cpp} and addrdb.{h|cpp}
ClosedPublic
Actions

Authored by deadalnix on Jun 19 2017, 19:46.

Details

Reviewers
freetrader
sickpig
awemany
kyuupichan
Group Reviewers
Restricted Project
Commits
rSTAGINGb6fd0cb912d9: Format addrman.{h|cpp} and addrdb.{h|cpp}
rABCb6fd0cb912d9: Format addrman.{h|cpp} and addrdb.{h|cpp}
Summary

As per title.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Jun 19 2017, 19:46
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 19 2017, 19:46
Harbormaster completed remote builds in B354: Diff 571.Jun 19 2017, 19:46
freetrader accepted this revision.Jun 19 2017, 20:32

I'm accepting, since I think those doxygen comments can be repaired later, as well as the comment typo.

src/addrman.h
109 ↗(On Diff #571)

I think clang-format did a hack job on this doxygen comment, unfortunately.

262 ↗(On Diff #571)

existing typo, it hurts my eyes

284 ↗(On Diff #571)

only slightly mutilated line breaking

This revision is now accepted and ready to land.Jun 19 2017, 20:32
deadalnix added inline comments.Jun 19 2017, 20:56
src/addrman.h
262 ↗(On Diff #571)

I think it is intended.

284 ↗(On Diff #571)

That's fine :) Code churn will bring better comments over time.

Closed by commit rABCb6fd0cb912d9: Format addrman.{h|cpp} and addrdb.{h|cpp} (authored by deadalnix, committed by deadalnix). · Explain WhyJun 19 2017, 20:57
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
64 lines
52 lines
250 lines
341 lines

Diff 580

View Options

src/addrdb.h

Loading...
View Options

src/addrdb.cpp

Loading...
View Options

src/addrman.h

Loading...
View Options

src/addrman.cpp

Loading...