Page MenuHomePhabricator
Differential D2389

[QA] fix mininode CAddress ser/deser
ClosedPublic
Actions

Authored by Fabien on Jan 23 2019, 10:45.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING7d3f92a4dc83: [QA] fix mininode CAddress ser/deser
rABC7d3f92a4dc83: [QA] fix mininode CAddress ser/deser
Summary

Optionally add time to CAddress serialization/deserialization.

Partial backport of core PR10387 (commit 158e1a6)

Depends on D2388

Test Plan
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR10387_part2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4658
Build 7379: Bitcoin ABC Buildbot (legacy)
Build 7378: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 23 2019, 10:45
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 23 2019, 10:45
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Jan 23 2019, 10:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jan 23 2019, 11:01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4658: Diff 6862.Jan 23 2019, 11:02
Fabien added a child revision: D2390: Connect to peers with NODE_NETWORK_LIMITED flag.Jan 23 2019, 11:18
jasonbcox edited the summary of this revision. (Show Details)Jan 23 2019, 17:12
jasonbcox accepted this revision.Jan 23 2019, 17:16
This revision is now accepted and ready to land.Jan 23 2019, 17:16
Closed by commit rABC7d3f92a4dc83: [QA] fix mininode CAddress ser/deser (authored by Jonas Schnelli <dev@jonasschnelli.ch>, committed by Fabien). · Explain WhyJan 24 2019, 15:15
This revision was automatically updated to reflect the committed changes.
Fabien removed a child revision: D2390: Connect to peers with NODE_NETWORK_LIMITED flag.Jan 24 2019, 15:26
Fabien added a commit: rSTAGING7d3f92a4dc83: [QA] fix mininode CAddress ser/deser.Sep 18 2019, 22:04

Revision Contents
Changeset List

PathSize
test/
functional/
test_framework/
17 lines

Diff 6862

View Options

test/functional/test_framework/messages.py

Loading...