As per title. Eventually, we'll be able to get rid of these GetConfig calls.
Details
Details
- Reviewers
freetrader sickpig kyuupichan awemany - Group Reviewers
Restricted Project - Commits
- rSTAGING3e61676ea4f6: Pass config down to InitializeNode
rABC3e61676ea4f6: Pass config down to InitializeNode
make check
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- config
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 378 Build 378: arc lint + arc unit
Event Timeline
Comment Actions
See message, looks good and make check passes.
| src/test/DoS_tests.cpp | ||
|---|---|---|
| 61 | Minor nit of the being anal about it variant: You factor out the config variable here and at the other, similar locations, this isn't really related to passing the config down - so maybe add 'and minor test refactoring' to the commit msg? | |
| src/test/DoS_tests.cpp | ||
|---|---|---|
| 61 | This people know already by looking at the code. | |