Page MenuHomePhabricator

Move NULLPTR macro so that it can be used by all unit tests
ClosedPublic

Authored by jasonbcox on Feb 4 2019, 23:01.

Details

Summary

Rather than copy-paste this to another test that I'm working on, it should be available to the whole unit test suite.

Test Plan

ninja check + CI diff should build (it uses an older version of Boost)

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Feb 4 2019, 23:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 4 2019, 23:01
Herald added a subscriber: schancel. · View Herald Transcript

I don't think making hacks more accessible is really a great idea.

Are you running into something that requires this ?

I wanted to use it here: https://reviews.bitcoinabc.org/D1894#inline-13587

It's technically not 100% necessary, as (RPCCommand*)nullptr works as well I think.

The alternative to both of those is to copy NULLPTR into that test file as well. Thoughts?

deadalnix accepted this revision.Feb 5 2019, 22:12
This revision is now accepted and ready to land.Feb 5 2019, 22:12
This revision was automatically updated to reflect the committed changes.