Page MenuHomePhabricator
Differential D2500

Move NULLPTR macro so that it can be used by all unit tests
ClosedPublic
Actions

Authored by jasonbcox on Feb 4 2019, 23:01.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGcc37dd10864e: Move NULLPTR macro so that it can be used by all unit tests
rABCcc37dd10864e: Move NULLPTR macro so that it can be used by all unit tests
Summary

Rather than copy-paste this to another test that I'm working on, it should be available to the whole unit test suite.

Test Plan

ninja check + CI diff should build (it uses an older version of Boost)

Diff Detail

Repository
rABC Bitcoin ABC
Branch
nullptr
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4875
Build 7813: Bitcoin ABC Buildbot (legacy)
Build 7812: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Feb 4 2019, 23:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 4 2019, 23:01
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Feb 4 2019, 23:02

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Feb 4 2019, 23:20

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4875: Diff 7175.Feb 4 2019, 23:20
jasonbcox added a child revision: D1894: Added RPCCommand base classes in preparation for RPC migration.Feb 4 2019, 23:32
deadalnix added a comment.Feb 5 2019, 00:03

I don't think making hacks more accessible is really a great idea.

deadalnix added a comment.Feb 5 2019, 00:04

Are you running into something that requires this ?

jasonbcox added a comment.Feb 5 2019, 01:21

I wanted to use it here: https://reviews.bitcoinabc.org/D1894#inline-13587

It's technically not 100% necessary, as (RPCCommand*)nullptr works as well I think.

The alternative to both of those is to copy NULLPTR into that test file as well. Thoughts?

deadalnix accepted this revision.Feb 5 2019, 22:12
This revision is now accepted and ready to land.Feb 5 2019, 22:12
Closed by commit rABCcc37dd10864e: Move NULLPTR macro so that it can be used by all unit tests (authored by jasonbcox). · Explain WhyFeb 5 2019, 22:31
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rSTAGINGcc37dd10864e: Move NULLPTR macro so that it can be used by all unit tests.Sep 18 2019, 22:17

Revision Contents
Changeset List

PathSize
src/
test/
9 lines
9 lines
9 lines

Diff 7175

View Options

src/test/radix_tests.cpp

Loading...
View Options

src/test/rcu_tests.cpp

Loading...
View Options

src/test/test_bitcoin.h

Loading...