Page MenuHomePhabricator

Move call to SetRPCWarmupFinished() so that it applies to the entire test framework
ClosedPublic

Authored by jasonbcox on Wed, Feb 6, 22:13.

Details

Summary

Encountered while writing D1894.
SetRPCWarmupFinished() needs to be called by the test framework since it is normally called via bitcoind's init cycle. Calling it in test_bitcoin is more appropriate since tests should expect the RPC to be in post-warmup by default, as the test framework already registers RPC commands.

Test Plan
make check
ninja check

Both on master and on D1894.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.