Encountered while writing D1894.
SetRPCWarmupFinished() needs to be called by the test framework since it is normally called via bitcoind's init cycle. Calling it in test_bitcoin is more appropriate since tests should expect the RPC to be in post-warmup by default, as the test framework already registers RPC commands.
Details
Details
- Reviewers
deadalnix Fabien - Group Reviewers
Restricted Project - Commits
- rSTAGING982780fad709: Move call to SetRPCWarmupFinished() so that it applies to the entire test…
rABC982780fad709: Move call to SetRPCWarmupFinished() so that it applies to the entire test…
make check ninja check
Both on master and on D1894.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- rpcwarmup
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 4892 Build 7847: Bitcoin ABC Buildbot (legacy) Build 7846: arc lint + arc unit