clean up CheckInputs() policy-ban logic and comments
ClosedPublic
Actions

Authored by markblundeberg on Feb 7 2019, 17:35.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING69ff7e29f430: clean up CheckInputs() policy-ban logic and comments
rABC69ff7e29f430: clean up CheckInputs() policy-ban logic and comments

Summary

I think this variable change makes it clearer what is actually going on.

Also, the comments here were out-of-date, referring to the now-mandatory flag STRICTENC, and referring to monolith upgrade.

Test Plan

make check and run functional tests

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_ban_comments

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4900
Build 7863: Bitcoin ABC Buildbot (legacy)
Build 7862: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Feb 7 2019, 17:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 7 2019, 17:35

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B4900: Diff 7215.Feb 7 2019, 17:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix accepted this revision.Feb 7 2019, 18:15

This revision is now accepted and ready to land.Feb 7 2019, 18:15

Closed by commit rABC69ff7e29f430: clean up CheckInputs() policy-ban logic and comments (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyFeb 7 2019, 18:20

This revision was automatically updated to reflect the committed changes.

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING69ff7e29f430: clean up CheckInputs() policy-ban logic and comments.Sep 18 2019, 22:18

Revision Contents
Changeset List

Path

Size

src/

validation.cpp

26 lines

Diff 7215

View Options

clean up CheckInputs() policy-ban logic and commentsClosedPublicActions