Page MenuHomePhabricator

Remove BytesIO dependency from feature_dersig
ClosedPublic

Authored by jasonbcox on Sat, Feb 9, 00:07.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rABC5f2ade873098: Remove BytesIO dependency from feature_dersig
Summary

Cleanup

Test Plan

test_runner.py feature_dersig

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Sat, Feb 9, 00:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptSat, Feb 9, 00:07
Herald added a subscriber: schancel. · View Herald Transcript
Fabien requested changes to this revision.Sat, Feb 9, 08:59
Fabien added inline comments.
test/functional/feature_dersig.py
48 ↗(On Diff #7261)

You can return directly and avoid the unused local variable

This revision now requires changes to proceed.Sat, Feb 9, 08:59
jasonbcox updated this revision to Diff 7282.Sun, Feb 10, 05:34

Rebase + removed unnecessary intermediate variable

Fabien accepted this revision.Sun, Feb 10, 09:38
This revision is now accepted and ready to land.Sun, Feb 10, 09:38
This revision was automatically updated to reflect the committed changes.