Remove BytesIO dependency from feature_dersig
ClosedPublic
Actions

Authored by jasonbcox on Feb 9 2019, 00:07.

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING5f2ade873098: Remove BytesIO dependency from feature_dersig
rABC5f2ade873098: Remove BytesIO dependency from feature_dersig

Summary

Cleanup

Test Plan

test_runner.py feature_dersig

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jasonbcox created this revision.Feb 9 2019, 00:07

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 9 2019, 00:07

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4933: Diff 7261.Feb 9 2019, 00:20

Fabien requested changes to this revision.Feb 9 2019, 08:59

Fabien added inline comments.

test/functional/feature_dersig.py
48 ↗	(On Diff #7261)	You can return directly and avoid the unused local variable

This revision now requires changes to proceed.Feb 9 2019, 08:59

Rebase + removed unnecessary intermediate variable

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4947: Diff 7282.Feb 10 2019, 05:49

Fabien accepted this revision.Feb 10 2019, 09:38

This revision is now accepted and ready to land.Feb 10 2019, 09:38

Closed by commit rABC5f2ade873098: Remove BytesIO dependency from feature_dersig (authored by jasonbcox). · Explain WhyFeb 11 2019, 18:04

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rSTAGING5f2ade873098: Remove BytesIO dependency from feature_dersig.Sep 18 2019, 22:22

Revision Contents
Changeset List

Path

Size

test/

functional/

feature_dersig.py

5 lines

Diff 7300

View Options

test/functional/feature_dersig.py

Remove BytesIO dependency from feature_dersigClosedPublicActions